Skip to content

[Hub Generated] Publish private branch 'release-netapp-Microsoft.NetApp-2023-05-01-preview'#26643

Merged
rkmanda merged 28 commits into
mainfrom
published/audunn/azure-rest-api-specs-pr/release-netapp-Microsoft.NetApp-2023-05-01-preview
Nov 29, 2023
Merged

[Hub Generated] Publish private branch 'release-netapp-Microsoft.NetApp-2023-05-01-preview'#26643
rkmanda merged 28 commits into
mainfrom
published/audunn/azure-rest-api-specs-pr/release-netapp-Microsoft.NetApp-2023-05-01-preview

Conversation

@audunn
Copy link
Copy Markdown
Member

@audunn audunn commented Nov 9, 2023

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • New API version. (Such PR should have been generated with OpenAPI Hub).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix swagger quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

Breaking changes review (Step 1)

  • If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
    you must follow the breaking changes process.
    IMPORTANT This applies even if:
    • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
    • You believe there is no need for you to request breaking change approval, for any reason.
      Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

  • If this PR is in purview of ARM review then automation will add the ARMReview label.
  • If you want to force ARM review, add the label yourself.
  • Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

@audunn
Copy link
Copy Markdown
Member Author

audunn commented Nov 9, 2023

The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR Azure/azure-rest-api-specs-pr/15169

@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app Bot commented Nov 9, 2023

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

@audunn
Copy link
Copy Markdown
Member Author

audunn commented Nov 10, 2023

Please get breaking change approved and come back for ARM review
@zizw123 @rkmanda
This was previously approved in private branch, this PR is to move that to public branch via OpenAPI Hub.
https://github.com/Azure/azure-rest-api-specs-pr/pull/15169

@openapi-workflow-bot openapi-workflow-bot Bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 13, 2023
@audunn
Copy link
Copy Markdown
Member Author

audunn commented Nov 14, 2023

@zizw123 @rkmanda will we need multiple review and breaking change review on the same changes when we are moving approved changes from private to public ?

@audunn
Copy link
Copy Markdown
Member Author

audunn commented Nov 15, 2023

@TimLovellSmith TimLovellSmith added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required labels Nov 17, 2023
@openapi-workflow-bot openapi-workflow-bot Bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 17, 2023
@audunn
Copy link
Copy Markdown
Member Author

audunn commented Nov 17, 2023

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 3 pipeline(s).

@AzureRestAPISpecReview AzureRestAPISpecReview added ARMChangesRequested BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required and removed ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review labels Nov 17, 2023
…ease-netapp-Microsoft.NetApp-2023-05-01-preview
@openapi-workflow-bot openapi-workflow-bot Bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 21, 2023
@raosuhas raosuhas added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Nov 21, 2023
@openapi-workflow-bot openapi-workflow-bot Bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 21, 2023
@raosuhas
Copy link
Copy Markdown
Member

Seems to be some kind of glitch in the automation since I dont see any new commits after tims approval. Adding signed off again to unblock

@audunn
Copy link
Copy Markdown
Member Author

audunn commented Nov 22, 2023

@raosuhas Breaking change label was also re-applied, can we remove it since it was aprpoved in the source PR? Hope we not need to do the review again.

@sjanamma sjanamma added Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go labels Nov 29, 2023
@audunn
Copy link
Copy Markdown
Member Author

audunn commented Nov 29, 2023

/pr RequestMerge

@rkmanda rkmanda merged commit f5aa38d into main Nov 29, 2023
@rkmanda rkmanda deleted the published/audunn/azure-rest-api-specs-pr/release-netapp-Microsoft.NetApp-2023-05-01-preview branch November 29, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go Approved-SdkBreakingChange-JavaScript Approved-SdkBreakingChange-Python ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-BreakingChange-Go CI-BreakingChange-JavaScript new-api-version resource-manager

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants