[storage-file-share] Migrate to core-rest-pipeline#26102
Conversation
xirzec
added
Client
xirzec
requested review from
EmmaZhu,
XiaoningLiu,
bterlson,
ckairen,
deyaaeldeen,
jeremymeng,
jiacfan,
ljian3377,
vinjiang and
witemple-msft
as code owners
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
| "ThirdPartyNotices.txt", | ||
| "dist/", | ||
| "dist-esm/src/", | ||
| "dist-esm/storage-blob/src/", |
There was a problem hiding this comment.
do we need to pack all of storage-blob, or do we plan to move common ones to storage-common?
There was a problem hiding this comment.
Yeah, ultimately I think this is solved by doing a storage-common package, but I wasn't able to just move those source files there since without it being a package they can't import anything from node_modules. I could probably carefully craft packing less, but if we change imports things might break so it felt safest to do overpack until we can centralize.
Open to other ideas too!
There was a problem hiding this comment.
The current storage way is to keep duplicate of same files in each packages, which has maintainence problems too. Yes hopefully we can move to the storage-common package soon.
|
/azp run js - storage-file-share- tests |
|
No pipelines are associated with this pull request. |
|
/azp run js - storage-file-share - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - storage-file-share - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Merging this to keep up the momentum, but I'm happy to address any remarks/concerns you have @EmmaZhu in a follow-up PR. The meta-plan is to finish getting all Storage SDKs updated in main and then do a round of reviews/testing. |
### Packages impacted by this PR `@azure/storage-file-share` ### Issues associated with this PR Azure#15813 ### Describe the problem that is addressed by this PR This PR migrates storage-file-share to the new core pipeline in the same way that storage-blob and storage-file-datalake were migrated. There are no changes to the public surface and existing recorded tests still pass. ### Provide a list of related PRs _(if any)_ Azure#24141, Azure#24835
### Packages impacted by this PR `@azure/storage-queue` ### Issues associated with this PR Fixes #15813 Closes #15594 ### Describe the problem that is addressed by this PR This PR migrates storage-queue to the new core pipeline in the same way that storage-file-share was migrated. There are no changes to the public surface and existing recorded tests still pass. ### Provide a list of related PRs _(if any)_ #26102
3 participants
Packages impacted by this PR
@azure/storage-file-shareIssues associated with this PR
#15813
Describe the problem that is addressed by this PR
This PR migrates storage-file-share to the new core pipeline in the same way that storage-blob and storage-file-datalake were migrated. There are no changes to the public surface and existing recorded tests still pass.
Provide a list of related PRs (if any)
#24141, #24835