Skip to content

[Identity] upgrade the msal dependencies due to security issue in jsonwebtoken#24458

Merged
KarishmaGhiya merged 5 commits intoAzure:hotfix/identity_3.1.3from
KarishmaGhiya:identity_3.1.3_security_fix
Jan 13, 2023
Merged

[Identity] upgrade the msal dependencies due to security issue in jsonwebtoken#24458
KarishmaGhiya merged 5 commits intoAzure:hotfix/identity_3.1.3from
KarishmaGhiya:identity_3.1.3_security_fix

Conversation

@KarishmaGhiya
Copy link
Copy Markdown
Member

@KarishmaGhiya KarishmaGhiya commented Jan 12, 2023

Packages impacted by this PR

@azure/identity

Issues associated with this PR

There's a CVE associated with this for jsonwebtoken vulnerability- https://nvd.nist.gov/vuln/detail/CVE-2022-23529

Describe the problem that is addressed by this PR

Upgrading the msal dependencies due to security issue in Auth0's jsonwebtoken library, which is a dependency of msal-node. The latest versions of msal libraries depend on the fix released by jsonwebtoken library version 9.0.0

Checklists

  • Added impacted package name to the issue description
  • Added a changelog (if necessary)

…oken library, which is a dependency of msal-node
@deyaaeldeen
Copy link
Copy Markdown
Member

Could you please merge latest main here? I don't expect changes in our lockfile.

@deyaaeldeen
Copy link
Copy Markdown
Member

Also, could you update the changelog?

@azure-sdk
Copy link
Copy Markdown
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-identity

@KarishmaGhiya
Copy link
Copy Markdown
Member Author

/azp run js - identity - ci

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Copy Markdown
Member

@xirzec xirzec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

KarishmaGhiya and others added 2 commits January 12, 2023 16:22
Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
@KarishmaGhiya KarishmaGhiya merged commit 22591b6 into Azure:hotfix/identity_3.1.3 Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants