Skip to content

Authentication events for Azure functions#22964

Merged
joheredi merged 26 commits intoAzure:mainfrom
ShaneMicro:authentication-events
Sep 21, 2022
Merged

Authentication events for Azure functions#22964
joheredi merged 26 commits intoAzure:mainfrom
ShaneMicro:authentication-events

Conversation

@ShaneMicro
Copy link
Member

Packages impacted by this PR

@azure/functions-authentication-events

Issues associated with this PR

N/A

Describe the problem that is addressed by this PR

Initial release of typescript/js wrapper for azure authentication events. (C# mono repo). Azure/azure-sdk-for-net#30465

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Pure just wrapper library that contains no logic.

Are there test cases added in this PR? (If not, why?)

Yes

Provide a list of related PRs (if any)

Azure/azure-sdk-for-net#30465

Command used to generate this PR:**(Applicable only to SDK release request PRs)

N/A

Checklists

  • [x ] Added impacted package name to the issue description
  • [ no] Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • [n/a ] Added a changelog (if necessary)

@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run js - [service] - ci

@ShaneMicro
Copy link
Member Author

/azp run prepare-pipelines

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 22964 in repo Azure/azure-sdk-for-js

@ShaneMicro ShaneMicro requested a review from ckairen as a code owner September 16, 2022 11:42
@joheredi
Copy link
Member

/azp run prepare-pipelines

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-functions-authentication-events

@joheredi joheredi merged commit 87ff3e6 into Azure:main Sep 21, 2022
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this pull request Mar 8, 2023
update typescript.md for graphservices (Azure#22964)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants