Conversation
jsquire
left a comment
There was a problem hiding this comment.
I did a high-level pass, mostly looking at general patterns. I did not deep-dive the implementation.
sdk/entra/WebJobs.Extensions.AuthenticationEvents/.gitattributes
Outdated
Show resolved
Hide resolved
sdk/entra/WebJobs.Extensions.AuthenticationEvents/CONTRIBUTING.md
Outdated
Show resolved
Hide resolved
...ra/WebJobs.Extensions.AuthenticationEvents/test/OpenApi/TokenIssuanceStartPreview10012021.cs
Outdated
Show resolved
Hide resolved
...bs.Extensions.AuthenticationEvents/test/WebJobs.Extensions.AuthenticationEvents.Tests.csproj
Outdated
Show resolved
Hide resolved
...bs.Extensions.AuthenticationEvents/test/WebJobs.Extensions.AuthenticationEvents.Tests.csproj
Outdated
Show resolved
Hide resolved
...bs.Extensions.AuthenticationEvents/test/WebJobs.Extensions.AuthenticationEvents.Tests.csproj
Outdated
Show resolved
Hide resolved
...ensions.AuthenticationEvents/test/WebJobs.Extensions.CustomAuthenticationExtension.Tests.xml
Outdated
Show resolved
Hide resolved
|
/azp prepare-pipelines |
|
@JoshLove-msft: Can you please take over for me here while I'm OOF? |
...AuthenticationEvents/src/WebJobs.Extensions.AuthenticationEvents/AuthEventBindingProvider.cs
Outdated
Show resolved
Hide resolved
....AuthenticationEvents/src/WebJobs.Extensions.AuthenticationEvents/AuthEventConfigProvider.cs
Show resolved
Hide resolved
...AuthenticationEvents/src/WebJobs.Extensions.AuthenticationEvents/AuthEventResponseHandler.cs
Outdated
Show resolved
Hide resolved
...AuthenticationEvents/src/WebJobs.Extensions.AuthenticationEvents/AuthEventResponseHandler.cs
Outdated
Show resolved
Hide resolved
|
I'm not able to comment on the files, but can we remove all of the binaries and snk files? |
sdk/entra/WebJobs.Extensions.AuthenticationEvents/stylecop.json
Outdated
Show resolved
Hide resolved
…/azure-sdk-for-net into authentication-events
|
This pull request is protected by Check Enforcer. |
|
/azp run prepare-pipelines |
|
Commenter does not have sufficient privileges for PR 30465 in repo Azure/azure-sdk-for-net |
|
/check-enforcer reset |
|
/check-enforcer evaluate |
|
/check-enforcer reset |
|
/check-enforcer evaluate |
|
What does "entra" as in sdk/entra stand for? Should this library to another existing service directory? |
|
/azp run prepare-pipelines |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Once prepare-pipelines finishes we need to run "/azp run net - entra - ci" to trigger the newly created pipeline. |
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
|
@jsquire I'm still interested in this question. What does "entra" as in sdk/entra stand for? Should this library to another existing service directory? |
"Entra" is the name of the Azure Resource Provider that the feature falls under; I don't claim to know what it stands for, but after architect discussions there was not a more obvious choice that didn't deviate from the established pattern. I have no objection to revisiting if you've got suggestions. |
|
I'm not opposed to this but just wanted to know more about it and I just wanted to make sure it was at least discussed. I would be interested to understand if this is actually a service or does it stand for something else because I've not see it anywhere else. |
@ShaneMicro would need to remind me of the origin. The discussion was a couple of months back. |
I also asked about this here - #30465 (comment) |
Krzysztof was also involved in those discussions, for what it's worth. |
|
This trigger falls under Entra Extensibility, more details can be found here: https://microsoft.sharepoint-df.com/:p:/t/AADIEFtogether/EfhIv6yM3a9Iu5JjJe_qrPYBnYXNTFOeGvqnORTo0zyxtw?e=tjsCy4&nav=eyJzSWQiOjIwNzYxMzc5NTQsImNJZCI6Mzg5NzkyMDMzNH0 |
* Main Library passing. * Tests Passing * Removed unused packages. * Fixed Link issues. * Fixed README.md * Fixed README.md 2 * Review fix 1 * Address Review 2 * Review 3 * Review 4 * Fix spelling. * Fixed path in ci.yml * Arch Review 5 * Added API * Arch Review 6 * Removed dependencies on Identity Protocol OpenAPI Libs * Clean up * Clean up ci.yml * Build fix * Updated ci * Refactor folder name * Update readme * clean up
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.