Skip to content

Authentication events#30465

Merged
jsquire merged 28 commits intoAzure:mainfrom
ShaneMicro:authentication-events
Sep 12, 2022
Merged

Authentication events#30465
jsquire merged 28 commits intoAzure:mainfrom
ShaneMicro:authentication-events

Conversation

@ShaneMicro
Copy link
Member

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

Copy link
Member

@jsquire jsquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a high-level pass, mostly looking at general patterns. I did not deep-dive the implementation.

@jsquire
Copy link
Member

jsquire commented Aug 12, 2022

/azp prepare-pipelines

@Azure Azure deleted a comment from azure-pipelines bot Aug 12, 2022
@jsquire
Copy link
Member

jsquire commented Aug 13, 2022

@JoshLove-msft: Can you please take over for me here while I'm OOF?

@JoshLove-msft
Copy link
Member

I'm not able to comment on the files, but can we remove all of the binaries and snk files?

@check-enforcer
Copy link

check-enforcer bot commented Sep 8, 2022

This pull request is protected by Check Enforcer.
For more information about how to run a pipeline against this pull request, see this.

@ShaneMicro
Copy link
Member Author

/azp run prepare-pipelines

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 30465 in repo Azure/azure-sdk-for-net

@ShaneMicro
Copy link
Member Author

/check-enforcer reset

@ShaneMicro
Copy link
Member Author

/check-enforcer evaluate

@ShaneMicro
Copy link
Member Author

/check-enforcer reset

@ShaneMicro
Copy link
Member Author

/check-enforcer evaluate

@weshaggard
Copy link
Member

What does "entra" as in sdk/entra stand for? Should this library to another existing service directory?

@weshaggard
Copy link
Member

/azp run prepare-pipelines

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@weshaggard
Copy link
Member

Once prepare-pipelines finishes we need to run "/azp run net - entra - ci" to trigger the newly created pipeline.

@ShaneMicro ShaneMicro requested a review from hallipr as a code owner September 12, 2022 13:16
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.Azure.WebJobs.Extensions.AuthenticationEvents

@jsquire jsquire merged commit 77b51cd into Azure:main Sep 12, 2022
@weshaggard
Copy link
Member

@jsquire I'm still interested in this question.

What does "entra" as in sdk/entra stand for? Should this library to another existing service directory?

@jsquire
Copy link
Member

jsquire commented Sep 12, 2022

What does "entra" as in sdk/entra stand for? Should this library to another existing service directory?

"Entra" is the name of the Azure Resource Provider that the feature falls under; I don't claim to know what it stands for, but after architect discussions there was not a more obvious choice that didn't deviate from the established pattern. I have no objection to revisiting if you've got suggestions.

@weshaggard
Copy link
Member

I'm not opposed to this but just wanted to know more about it and I just wanted to make sure it was at least discussed. I would be interested to understand if this is actually a service or does it stand for something else because I've not see it anywhere else.

@jsquire
Copy link
Member

jsquire commented Sep 12, 2022

I would be interested to understand if this is actually a service or does it stand for something else because I've not see it anywhere else.

@ShaneMicro would need to remind me of the origin. The discussion was a couple of months back.

@JoshLove-msft
Copy link
Member

I would be interested to understand if this is actually a service or does it stand for something else because I've not see it anywhere else.

@ShaneMicro would need to remind me of the origin. The discussion was a couple of months back.

I also asked about this here - #30465 (comment)

@jsquire
Copy link
Member

jsquire commented Sep 12, 2022

I also asked about this here - #30465 (comment)

Krzysztof was also involved in those discussions, for what it's worth.

@ShaneMicro
Copy link
Member Author

sofiar-msft pushed a commit to sofiar-msft/azure-sdk-for-net that referenced this pull request Dec 7, 2022
* Main Library passing.

* Tests Passing

* Removed unused packages.

* Fixed Link issues.

* Fixed README.md

* Fixed README.md 2

* Review fix 1

* Address Review 2

* Review 3

* Review 4

* Fix spelling.

* Fixed path in ci.yml

* Arch Review 5

* Added API

* Arch Review 6

* Removed dependencies on Identity Protocol OpenAPI Libs

* Clean up

* Clean up ci.yml

* Build fix

* Updated ci

* Refactor folder name

* Update readme

* clean up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants