Skip to content

[Event Hubs, Service Bus] Remove unnecessary dependency on @types/long #22923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timovv merged 3 commits into from
Aug 17, 2022
Merged

[Event Hubs, Service Bus] Remove unnecessary dependency on @types/long #22923

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
abee0d6
[engsys] Remove dependency on @types/long
timovv Aug 17, 2022
87f5600
Fix typing in sendAndSchedule test?
timovv Aug 17, 2022
712bedb
add API changes...
timovv Aug 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion sdk/eventhub/event-hubs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,6 @@
"@types/chai-as-promised": "^7.1.0",
"@types/chai-string": "^1.4.1",
"@types/debug": "^4.1.4",
"@types/long": "^4.0.1",
"@types/mocha": "^7.0.2",
"@types/node": "^12.0.0",
"@types/sinon": "^9.0.4",
Expand Down
1 change: 0 additions & 1 deletion sdk/servicebus/service-bus/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,6 @@
"@azure/core-xml": "^1.0.0",
"@azure/logger": "^1.0.0",
"@types/is-buffer": "^2.0.0",
"@types/long": "^4.0.1",
"buffer": "^6.0.0",
"is-buffer": "^2.0.3",
"jssha": "^3.1.0",
Expand Down
12 changes: 6 additions & 6 deletions sdk/servicebus/service-bus/review/service-bus.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import { CommonClientOptions } from '@azure/core-client';
import { delay } from '@azure/core-amqp';
import { Delivery } from 'rhea-promise';
import { HttpMethods } from '@azure/core-rest-pipeline';
import { default as Long_2 } from 'long';
import Long from 'long';
import { MessagingError } from '@azure/core-amqp';
import { NamedKeyCredential } from '@azure/core-auth';
import { OperationOptions } from '@azure/core-client';
Expand Down Expand Up @@ -205,7 +205,7 @@ export function parseServiceBusConnectionString(connectionString: string): Servi

// @public
export interface PeekMessagesOptions extends OperationOptionsBase {
fromSequenceNumber?: Long_2;
fromSequenceNumber?: Long;
// @beta
omitMessageBody?: boolean;
}
Expand Down Expand Up @@ -467,7 +467,7 @@ export interface ServiceBusReceivedMessage extends ServiceBusMessage {
lockedUntilUtc?: Date;
readonly lockToken?: string;
readonly _rawAmqpMessage: AmqpAnnotatedMessage;
readonly sequenceNumber?: Long_2;
readonly sequenceNumber?: Long;
readonly state: "active" | "deferred" | "scheduled";
}

Expand All @@ -489,7 +489,7 @@ export interface ServiceBusReceiver {
identifier: string;
isClosed: boolean;
peekMessages(maxMessageCount: number, options?: PeekMessagesOptions): Promise<ServiceBusReceivedMessage[]>;
receiveDeferredMessages(sequenceNumbers: Long_2 | Long_2[], options?: OperationOptionsBase): Promise<ServiceBusReceivedMessage[]>;
receiveDeferredMessages(sequenceNumbers: Long | Long[], options?: OperationOptionsBase): Promise<ServiceBusReceivedMessage[]>;
receiveMessages(maxMessageCount: number, options?: ReceiveMessagesOptions): Promise<ServiceBusReceivedMessage[]>;
receiveMode: "peekLock" | "receiveAndDelete";
renewMessageLock(message: ServiceBusReceivedMessage): Promise<Date>;
Expand Down Expand Up @@ -517,13 +517,13 @@ export interface ServiceBusRuleManager {

// @public
export interface ServiceBusSender {
cancelScheduledMessages(sequenceNumbers: Long_2 | Long_2[], options?: OperationOptionsBase): Promise<void>;
cancelScheduledMessages(sequenceNumbers: Long | Long[], options?: OperationOptionsBase): Promise<void>;
close(): Promise<void>;
createMessageBatch(options?: CreateMessageBatchOptions): Promise<ServiceBusMessageBatch>;
entityPath: string;
identifier: string;
isClosed: boolean;
scheduleMessages(messages: ServiceBusMessage | ServiceBusMessage[] | AmqpAnnotatedMessage | AmqpAnnotatedMessage[], scheduledEnqueueTimeUtc: Date, options?: OperationOptionsBase): Promise<Long_2[]>;
scheduleMessages(messages: ServiceBusMessage | ServiceBusMessage[] | AmqpAnnotatedMessage | AmqpAnnotatedMessage[], scheduledEnqueueTimeUtc: Date, options?: OperationOptionsBase): Promise<Long[]>;
sendMessages(messages: ServiceBusMessage | ServiceBusMessage[] | ServiceBusMessageBatch | AmqpAnnotatedMessage | AmqpAnnotatedMessage[], options?: OperationOptionsBase): Promise<void>;
}

Expand Down
2 changes: 1 addition & 1 deletion sdk/servicebus/service-bus/test/public/sendAndSchedule.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ describe("Sender Tests", () => {
compareSequenceNumbers(sequenceNumbers[0], sequenceNumbers[2]);
compareSequenceNumbers(sequenceNumbers[1], sequenceNumbers[2]);

function compareSequenceNumbers(sequenceNumber1: Long.Long, sequenceNumber2: Long.Long): void {
function compareSequenceNumbers(sequenceNumber1: Long, sequenceNumber2: Long): void {
should.equal(
sequenceNumber1.compare(sequenceNumber2) !== 0,
true,
Expand Down