Skip to content

[Event Hubs, Service Bus] Remove unnecessary dependency on @types/long#22923

Merged
timovv merged 3 commits intoAzure:mainfrom
timovv:engsys/update-long-types
Aug 17, 2022
Merged

[Event Hubs, Service Bus] Remove unnecessary dependency on @types/long#22923
timovv merged 3 commits intoAzure:mainfrom
timovv:engsys/update-long-types

Conversation

@timovv
Copy link
Copy Markdown
Member

@timovv timovv commented Aug 17, 2022

Packages impacted by this PR

  • @azure/event-hubs
  • @azure/service-bus

Issues associated with this PR

Describe the problem that is addressed by this PR

@types/long is a stub type package. The long package provides its own type definitions, so the dependency on the type definitions package is unnecessary. This PR removes the unnecessary dependency.

Copy link
Copy Markdown
Contributor

@HarshaNalluru HarshaNalluru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@azure-sdk
Copy link
Copy Markdown
Collaborator

API change check

API changes are not detected in this pull request.

@timovv timovv requested review from bterlson and xirzec as code owners August 17, 2022 18:58
@timovv timovv merged commit 51045d6 into Azure:main Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dependency package @types/long has a new version available

4 participants