Skip to content

[engsys] Enable credscan in PR/Ci #20312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sima-zhu merged 1 commit into from
Feb 14, 2022
Merged

[engsys] Enable credscan in PR/Ci #20312

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 21 additions & 12 deletions eng/pipelines/templates/jobs/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,16 +67,25 @@ jobs:
ServiceDirectory: ${{ parameters.ServiceDirectory }}
TestPipeline: ${{ parameters.TestPipeline }}

- ${{ if ne(parameters.RunUnitTests, false) }}:
- template: /eng/common/pipelines/templates/jobs/archetype-sdk-tests-generate.yml
parameters:
JobTemplatePath: /eng/pipelines/templates/jobs/ci.tests.yml
MatrixConfigs: ${{ parameters.MatrixConfigs }}
MatrixFilters: ${{ parameters.MatrixFilters }}
MatrixReplace: ${{ parameters.MatrixReplace }}
CloudConfig:
Cloud: Public
AdditionalParameters:
- job: Compliance
Copy link
Copy Markdown
Member

@maorleger maorleger Feb 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know enough to approve but just want to say I am very excited to have this!

pool:
name: azsdk-pool-mms-win-2019-general
vmImage: MMS2019
steps:
- template: /eng/common/pipelines/templates/steps/credscan.yml
parameters:
ServiceDirectory: ${{ parameters.ServiceDirectory }}
Artifacts: ${{ parameters.Artifacts }}
TestProxy: ${{ parameters.TestProxy }}

- ${{ if ne(parameters.RunUnitTests, false) }}:
- template: /eng/common/pipelines/templates/jobs/archetype-sdk-tests-generate.yml
Copy link
Copy Markdown
Member

@jeremymeng jeremymeng Feb 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks that - template now has more indentation? It was aligning with $ previously. Not sure if it matters though.

Copy link
Copy Markdown
Member

@weshaggard weshaggard Feb 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes not only does the indention look off it looks like this is in the incorrect spot. It should be above the Compliance job.

Copy link
Copy Markdown
Member

@weshaggard weshaggard Feb 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually nevermind about the ordering as this is an entire job template so it can go above or below the Compliance job. However do double check the indention.

Copy link
Copy Markdown
Contributor Author

@sima-zhu sima-zhu Feb 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is working as expected and indentation is correct.

parameters:
JobTemplatePath: /eng/pipelines/templates/jobs/ci.tests.yml
MatrixConfigs: ${{ parameters.MatrixConfigs }}
MatrixFilters: ${{ parameters.MatrixFilters }}
MatrixReplace: ${{ parameters.MatrixReplace }}
CloudConfig:
Cloud: Public
AdditionalParameters:
ServiceDirectory: ${{ parameters.ServiceDirectory }}
Artifacts: ${{ parameters.Artifacts }}
TestProxy: ${{ parameters.TestProxy }}