[engsys] Enable credscan in PR/Ci#20312
Conversation
| TestProxy: ${{ parameters.TestProxy }} | ||
|
|
||
| - ${{ if ne(parameters.RunUnitTests, false) }}: | ||
| - template: /eng/common/pipelines/templates/jobs/archetype-sdk-tests-generate.yml |
There was a problem hiding this comment.
Looks that - template now has more indentation? It was aligning with $ previously. Not sure if it matters though.
There was a problem hiding this comment.
Yes not only does the indention look off it looks like this is in the incorrect spot. It should be above the Compliance job.
There was a problem hiding this comment.
Actually nevermind about the ordering as this is an entire job template so it can go above or below the Compliance job. However do double check the indention.
There was a problem hiding this comment.
It is working as expected and indentation is correct.
jeremymeng
changed the title
jeremymeng
left a comment
jeremymeng
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for enabling it!
| CloudConfig: | ||
| Cloud: Public | ||
| AdditionalParameters: | ||
| - job: Compliance |
There was a problem hiding this comment.
Don't know enough to approve but just want to say I am very excited to have this!
weshaggard
left a comment
weshaggard
left a comment
There was a problem hiding this comment.
Change looks good but lets please wait until we sort out the baseline file and the v2/v3 issue before merging this.
4 participants
Enable credscan in PR/Ci