Skip to content

[azureBus] Typescript samples: fix type error & tsconfig.json #20227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fengdi721 wants to merge 1 commit into from
Closed

[azureBus] Typescript samples: fix type error & tsconfig.json #20227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sdk/servicebus/service-bus/samples/v7/typescript/src/advanced/sessionRoundRobin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ async function receiveFromNextSession(serviceBusClient: ServiceBusClient): Promi
) {
console.log(`INFO: no available sessions, sleeping for ${delayOnErrorMs}`);
} else {
await processError(err, undefined);
await processError(<Error>err, undefined);
}

await delay(delayOnErrorMs);
Expand Down Expand Up @@ -128,7 +128,7 @@ async function receiveFromNextSession(serviceBusClient: ServiceBusClient): Promi
await sessionFullyRead;
await sessionClosed("idle_timeout", sessionReceiver.sessionId);
} catch (err) {
await processError(err, sessionReceiver.sessionId);
await processError(<Error>err, sessionReceiver.sessionId);
Copy link
Copy Markdown
Member

@witemple-msft witemple-msft Feb 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

err as Error is preferable to using the <Error>err syntax.

await sessionClosed("error", sessionReceiver.sessionId);
} finally {
await sessionReceiver.close();
Expand Down
2 changes: 1 addition & 1 deletion sdk/servicebus/service-bus/samples/v7/typescript/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@
"rootDir": "src"
},
"include": [
"src/**.ts"
"src/**/*.ts"
]
}