[azureBus] Typescript samples: fix type error & tsconfig.json#20227
[azureBus] Typescript samples: fix type error & tsconfig.json#20227fengdi721 wants to merge 1 commit intoAzure:mainfrom
Conversation
fengdi721
requested review from
HarshaNalluru,
deyaaeldeen,
jeremymeng,
ramya-rao-a and
witemple-msft
as code owners
ghost
added
Service Bus
customer-reported
|
Thank you for your contribution feng-di! We will review the pull request and get back to you soon. |
|
|
witemple-msft
left a comment
witemple-msft
left a comment
There was a problem hiding this comment.
The src/**.ts looks like a dev-tool bug. I'll update the tool to generate src/**/*.ts instead.
| await sessionClosed("idle_timeout", sessionReceiver.sessionId); | ||
| } catch (err) { | ||
| await processError(err, sessionReceiver.sessionId); | ||
| await processError(<Error>err, sessionReceiver.sessionId); |
There was a problem hiding this comment.
err as Error is preferable to using the <Error>err syntax.
jeremymeng
added
the
Client
ghost
added
the
no-recent-activity
|
Hi @feng-di. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
ghost
closed this
|
Hi @feng-di. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass. |
[Microsoft.StorageSync] New API version 2022-06-01 (Azure#20227) * Adds base for updating Microsoft.StorageSync from version stable/2020-09-01 to version 2022-06-01 * Updates readme * Updates API version in new specs and examples * Swagger API Spec Update for adding Low Disk Mode to Storage Sync (Azure#19725) * Added Low Disk Mode property * Updated API Spec for introducing Low Disk Mode * Updated Examples for API Spec for Low Disk Mode * Updated Examples for Cloud Tiering Status (Azure#19885) * [Microsoft.StorageSync] Add AFS file share metadata certificate public keys API to version 2022-06-01 (S360 compliance) (Azure#20517) * Fix readme.md file so that tag information includes full API version 2022-06-01 * Add afs share metadata certificate public keys API https://portal.azure-devex-tools.com/amekpis/completeness/detail?errorId=DBF8D800-EB0B-48E0-B665-BC91CB1A17B9 * Fix casing of afssharemetadatacertificatepublickeys * Temporarily rename examples file to fix casing issue. * Fix casing of new example file Co-authored-by: ankushbindlish2 <34896519+ankushbindlish2@users.noreply.github.com> Co-authored-by: Juan Carlos Juarez <106784687+jcjuarez-msft@users.noreply.github.com>
3 participants
Packages impacted by this PR
servicebus/service-bus/samples/v7/typescriptIssues associated with this PR
N/C
Describe the problem that is addressed by this PR
npm run buildfailed because of compile error :I added "type assertion" to fix this compile error.
advanced folderare not included in the compile process, so i updated thetsconfig.jsonto include them.What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
N/C
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
N/C
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists