Skip to content

[Metrics Advisor] skip create changepoint feedback tests due to potential service issues #20105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KarishmaGhiya merged 2 commits into from
Jan 28, 2022
Merged

[Metrics Advisor] skip create changepoint feedback tests due to potential service issues #20105

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6202d4
skip create changepoint feedbcak tests due to potential service issues
KarishmaGhiya Jan 27, 2022
aea253d
update te comments and skip period feedback tests
KarishmaGhiya Jan 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions sdk/metricsadvisor/ai-metrics-advisor/test/public/advisorclient.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,7 +541,9 @@ matrix([[true, false]] as const, async (useAad) => {
}
});

it("creates ChangePoint feedback", async function () {
// Skipped due to potential errors on service side
// Issue - https://github.com/Azure/azure-sdk-for-js/issues/19747
it.skip("creates ChangePoint feedback", async function () {
Copy link
Copy Markdown
Member

@maorleger maorleger Jan 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I usually like to leave a comment explaining why it's skipped and linking to the issue made to re-enable the test. Up to you though!

const changePointFeedback: MetricChangePointFeedback = {
metricId: testEnv.METRICS_ADVISOR_AZURE_SQLSERVER_METRIC_ID_1,
feedbackType: "ChangePoint",
Expand All @@ -558,7 +560,9 @@ matrix([[true, false]] as const, async (useAad) => {
}
});

it("creates Period feedback", async function () {
// Skipped due to potential errors on service side
// Issue - https://github.com/Azure/azure-sdk-for-js/issues/19747
it.skip("creates Period feedback", async function () {
const periodFeedback: MetricPeriodFeedback = {
metricId: testEnv.METRICS_ADVISOR_AZURE_SQLSERVER_METRIC_ID_1,
feedbackType: "Period",
Expand Down