Skip to content

[Metrics Advisor] skip create changepoint feedback tests due to potential service issues#20105

Merged
KarishmaGhiya merged 2 commits intoAzure:mainfrom
KarishmaGhiya:metrics-feedback
Jan 28, 2022
Merged

[Metrics Advisor] skip create changepoint feedback tests due to potential service issues#20105
KarishmaGhiya merged 2 commits intoAzure:mainfrom
KarishmaGhiya:metrics-feedback

Conversation

@KarishmaGhiya
Copy link
Copy Markdown
Member

@KarishmaGhiya KarishmaGhiya commented Jan 27, 2022

Packages impacted by this PR

Metrics Advisor

Issues associated with this PR

Fixes #19546

Describe the problem that is addressed by this PR

Creation of changepoint feedback tests with API authentication failing with "Bad request" due to service side issues. Skipping till it gets resolved on the service side. Updated this issue to track this test too - #19747

Are there test cases added in this PR? (If not, why?)

Skipping tests

Copy link
Copy Markdown
Member

@maorleger maorleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

});

it("creates ChangePoint feedback", async function () {
it.skip("creates ChangePoint feedback", async function () {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I usually like to leave a comment explaining why it's skipped and linking to the issue made to re-enable the test. Up to you though!

Copy link
Copy Markdown
Member

@jeremymeng jeremymeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@KarishmaGhiya KarishmaGhiya merged commit 55ad309 into Azure:main Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Metrics Advisor] [AAD] MetricsAdvisorClient Feedback creates ChangePoint feedback failing in nightly runs

3 participants