Skip to content

[sort-imports] enforce sort-imports rule in data-tables #20008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremymeng merged 2 commits into from
Jan 24, 2022
Merged

[sort-imports] enforce sort-imports rule in data-tables #20008

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9de0e6
sorted
bzhang0 Jan 23, 2022
6feb753
prettier
bzhang0 Jan 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sdk/tables/data-tables/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"plugins": ["@azure/azure-sdk"],
"extends": ["plugin:@azure/azure-sdk/azure-sdk-base"],
"rules": {
"@typescript-eslint/ban-types": "warn"
"@typescript-eslint/ban-types": "warn",
"sort-imports": "error"
}
}
6 changes: 3 additions & 3 deletions sdk/tables/data-tables/src/TableTransaction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@
import {
DeleteTableEntityOptions,
TableEntity,
TableServiceClientOptions,
TableTransactionEntityResponse,
TableTransactionResponse,
TransactionAction,
UpdateMode,
UpdateTableEntityOptions,
TableServiceClientOptions,
} from "./models";
import {
NamedKeyCredential,
Expand All @@ -22,9 +22,9 @@ import {
import {
OperationOptions,
ServiceClient,
ServiceClientOptions,
serializationPolicy,
serializationPolicyName,
ServiceClientOptions,
} from "@azure/core-client";
import {
Pipeline,
Expand All @@ -44,6 +44,7 @@ import {
transactionRequestAssemblePolicy,
transactionRequestAssemblePolicyName,
} from "./TablePolicies";
import { STORAGE_SCOPE } from "./utils/constants";
import { SpanStatusCode } from "@azure/core-tracing";
import { TableClientLike } from "./utils/internalModels";
import { TableServiceErrorOdataError } from "./generated";
Expand All @@ -53,7 +54,6 @@ import { getAuthorizationHeader } from "./tablesNamedCredentialPolicy";
import { getTransactionHeaders } from "./utils/transactionHeaders";
import { isCosmosEndpoint } from "./utils/isCosmosEndpoint";
import { signURLWithSAS } from "./tablesSASTokenPolicy";
import { STORAGE_SCOPE } from "./utils/constants";

/**
* Helper to build a list of transaction actions
Expand Down
2 changes: 1 addition & 1 deletion sdk/tables/data-tables/test/internal/browser/generateSas.browser.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT license.

import { assert } from "chai";
import { AzureNamedKeyCredential, generateTableSas } from "../../../src";
import { assert } from "chai";

// This file is empty as sas generation is not supported in browsers
describe("generateSas Browser", () => {
Expand Down
4 changes: 2 additions & 2 deletions sdk/tables/data-tables/test/internal/node/generateSas.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT license.

import { assert } from "chai";
import { AzureNamedKeyCredential, generateAccountSas, generateTableSas } from "../../../src";
import * as sinon from "sinon";
import { AzureNamedKeyCredential, generateAccountSas, generateTableSas } from "../../../src";
import { assert } from "chai";

describe("SAS generation", function () {
describe("generateTableSAS", () => {
Expand Down
6 changes: 3 additions & 3 deletions sdk/tables/data-tables/test/internal/tableTransaction.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@
// Licensed under the MIT license.

import {
HttpClient,
PipelineResponse,
createHttpHeaders,
createPipelineRequest,
HttpClient,
} from "@azure/core-rest-pipeline";
import { assert } from "chai";
import { TableTransaction, parseTransactionResponse } from "../../src/TableTransaction";
import { TableClient } from "../../src/TableClient";
import { parseTransactionResponse, TableTransaction } from "../../src/TableTransaction";
import { assert } from "chai";

describe("TableTransaction", () => {
describe("parseTransactionResponse", () => {
Expand Down