[sort-imports] enforce sort-imports rule in data-tables#20008
Merged
jeremymeng merged 2 commits intoAzure:mainfrom Jan 24, 2022
Merged
[sort-imports] enforce sort-imports rule in data-tables#20008jeremymeng merged 2 commits intoAzure:mainfrom
sort-imports rule in data-tables#20008jeremymeng merged 2 commits intoAzure:mainfrom
Conversation
ghost
added
Tables
customer-reported
|
Thank you for your contribution bzhang0! We will review the pull request and get back to you soon. |
ghost
added
the
Impact++
joheredi
approved these changes
Jan 24, 2022
Member
joheredi
left a comment
joheredi
left a comment
There was a problem hiding this comment.
LGTM! Thanks for sending out this PR!
Contributor
|
@joheredi Are the build failures in this PR related to the changes here? |
Member
|
The failures are unrelated. The same started happening since 01/20 https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1315633&view=results (Microsoft Internal) Overriding the check-enforcer... |
Member
|
/check-enforcer override |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reinforces the changes made in #19055 by changing the subdirectory's linting rule to
"sort-imports": "error".This affects the directory under
sdk/tables/data-tables.