[core] fix nightly core build pipeline#19480
Merged
jeremymeng merged 1 commit intoAzure:mainfrom Dec 21, 2021
Merged
Conversation
while we may want to handle setting dev versions better, this unblocks the nightly build pipeline similarly to what PR Azure#18977 did.
ghost
added
the
joheredi
approved these changes
Dec 21, 2021
Member
joheredi
left a comment
joheredi
left a comment
There was a problem hiding this comment.
Thanks @jeremymeng!
@praveenkuttappan - Do you have any ideas on how we can get better handling of dev versions? We have had to be reactive to nightly build breaks due to the way CI installs dependencies, it ends up trying to resolve from npm, but the dependency hasn't been released
deyaaeldeen
approved these changes
Dec 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
while we may want to handle setting dev versions better, this unblocks the
nightly build pipeline similarly to what PR #18977 did.