[core-client] Fix Core client nightly

[joheredi]

TL;DR - Nightly builds are broken because core-client now depends on a property not existing in the latest published in NPM. Updating the dependency on core-rest-pipeline so that nightly ci links to the same alpha version of core-rest-pipeline.

Details
Core pipeline nightly builds are failing with the following error:

src/authorizeRequestOnClaimChallenge.ts(67,37): error TS2339: Property 'logger' does not exist on type 'AuthorizeRequestOnChallengeOptions'.
test/authorizeRequestOnClaimChallenge.spec.ts(383,7): error TS2345: Argument of type '{ getAccessToken(scopes: string[], getTokenOptions: GetTokenOptions): Promise<{ token: string; expiresOnTimestamp: number; }>; scopes: never[]; response: { ...; }; request: PipelineRequest; logger: any; }' is not assignable to parameter of type 'AuthorizeRequestOnChallengeOptions'.
Object literal may only specify known properties, and 'logger' does not exist in type 'AuthorizeRequestOnChallengeOptions'.
test/authorizeRequestOnClaimChallenge.spec.ts(429,7): error TS2345: Argument of type '{ getAccessToken(scopes: string[], getTokenOptions: GetTokenOptions): Promise<{ token: string; expiresOnTimestamp: number; }>; scopes: never[]; response: { ...; }; request: PipelineRequest; logger: any; }' is not assignable to parameter of type 'AuthorizeRequestOnChallengeOptions'.
Object literal may only specify known properties, and 'logger' does not exist in type 'AuthorizeRequestOnChallengeOptions'.

The problem started a few weeks ago when #18467 was merged. It adds a logger property to AuthorizeRequestOnChallengeOptions, AuthorizeRequestOptions and BearerTokenAuthenticationPolicyOptions . In the same PR @azure/core-client starts consuming this new property *authorizeRequestOnClaimChallenge.ts).

However @azure/core-client's dependency on @azure/core-rest-pipeline wasn't updated and remained on ^1.1.0. In local development and regular CIs this works fine because RUSH would link the local versions of the SDKs which would contain the newest changes. The problem comes when creating dev-versions, the logic in our tooling determines that ^1.1.0 is enough and doesn't update @azure/core-client to the current alpha version, this makes the dependency on @azure/core-rest-pipeline to point to the latest in NPM 1.3.2 which doesn't have the new property and causes the build break.

The fix is simple, just need to update the dependency on core-rest-pipeline to ^1.3.3 so that nightly build tooling would link it to the alpha versions being produced.

Ran a test pipeline (link) based on these changes and the Build libraries step works fine (canceled to avoid releasing alpha builds off an unmerged branch)

[joheredi]

/azp run js - core

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[sadasant]

I think this should be fine. Next time a release date comes, we should release these two packages together anyway.

[deyaaeldeen]

Thanks for catching this!