Skip to content

We now recommend 2s as a polling period for standard sessions #18625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
4 commits merged into from
Nov 16, 2021
Merged

We now recommend 2s as a polling period for standard sessions #18625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d742023
We now recommend 2s as a polling period for standard sessions
matyrr-havok Nov 10, 2021
2347ebc
Use ===
matyrr-havok Nov 11, 2021
c36265d
Changelog
matyrr-havok Nov 11, 2021
5b9fec6
Merge branch 'main' into MalcolmTyrrell/pollingIntervalImprovements
matyrr-havok Nov 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sdk/remoterendering/mixed-reality-remote-rendering/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## 1.0.0-beta.2 (Unreleased)

- The RenderingSessionPoller now defaults to a 2s polling interval when waiting for a Standard sized rendering VM. For Premium, 10s is still used.
- Update samples to depend on Azure Identity 2.0.1.

## 1.0.0-beta.1 (2021-09-21)
Expand Down
12 changes: 9 additions & 3 deletions sdk/remoterendering/mixed-reality-remote-rendering/src/lro/renderingSessionPoller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Licensed under the MIT license.

import { PollOperationState, Poller, PollOperation } from "@azure/core-lro";
import { KnownRenderingSessionStatus } from "../generated/models/index";
import { KnownRenderingSessionStatus, KnownRenderingServerSize } from "../generated/models/index";
import { getSessionInternal, endSessionInternal } from "../internal/commonQueries";
import { AbortSignalLike } from "@azure/abort-controller";
import { RemoteRendering } from "../generated/operationsInterfaces";
Expand Down Expand Up @@ -132,7 +132,7 @@ export class RenderingSessionPoller extends Poller<
/**
* Defines how much time the poller is going to wait before making a new request to the service.
*/
public intervalInMs: number = 10000;
public intervalInMs: number;

constructor(
accountId: string,
Expand All @@ -147,7 +147,13 @@ export class RenderingSessionPoller extends Poller<
new RenderingSessionOperationStateImpl(renderingSession)
)
);
this.intervalInMs = options.intervalInMs ? options.intervalInMs : 10000;
if (options.intervalInMs) {
this.intervalInMs = options.intervalInMs;
} else if (renderingSession.size === KnownRenderingServerSize.Standard) {
Copy link
Copy Markdown
Member

@rikogeln-havok rikogeln-havok Nov 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: could we add a comment here why this is done? Something like "Standard session startup time is now in the range of x-y s. Because of this we want to poll more frequently in order to detect a ready session with less delay. "

this.intervalInMs = 2000;
} else {
this.intervalInMs = 10000;
}
}

/**
Expand Down