We now recommend 2s as a polling period for standard sessions#18625
Merged
4 commits merged intoAzure:mainfrom Nov 16, 2021
Merged
We now recommend 2s as a polling period for standard sessions#186254 commits merged intoAzure:mainfrom
4 commits merged intoAzure:mainfrom
Conversation
ghost
added
the
Member
Author
|
/azp run js - mixedreality-remoterendering - tests |
|
No pipelines are associated with this pull request. |
Member
Author
|
/azp run js - mixed-reality-remote-rendering - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
The unit tests do not test with premium sessions, so I tested manually. |
| this.intervalInMs = options.intervalInMs ? options.intervalInMs : 10000; | ||
| if (options.intervalInMs) { | ||
| this.intervalInMs = options.intervalInMs; | ||
| } else if (renderingSession.size === KnownRenderingServerSize.Standard) { |
Member
There was a problem hiding this comment.
nit: could we add a comment here why this is done? Something like "Standard session startup time is now in the range of x-y s. Because of this we want to poll more frequently in order to detect a ready session with less delay. "
rikogeln-havok
approved these changes
Nov 15, 2021
|
Hello @MalcolmTyrrell! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.