Skip to content

remove _response from response types #16019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KarishmaGhiya merged 8 commits into from
Jun 26, 2021
Merged

remove _response from response types #16019

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6fe5323
remove _response types
KarishmaGhiya Jun 25, 2021
e7cc103
remove _response types
KarishmaGhiya Jun 25, 2021
fc88b30
api review file
KarishmaGhiya Jun 25, 2021
6128c2e
remove _response types
KarishmaGhiya Jun 26, 2021
b6355c7
remove _response types
KarishmaGhiya Jun 26, 2021
92f4fde
remove empty brackets
KarishmaGhiya Jun 26, 2021
8ee5fa3
remove empty brackets
KarishmaGhiya Jun 26, 2021
9544b9e
remove empty brackets
KarishmaGhiya Jun 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
112 changes: 6 additions & 106 deletions sdk/metricsadvisor/ai-metrics-advisor/review/ai-metrics-advisor.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

```ts

import * as coreHttp from '@azure/core-http';
import { OperationOptions } from '@azure/core-http';
import { PagedAsyncIterableIterator } from '@azure/core-paging';
import { PipelineOptions } from '@azure/core-http';
Expand All @@ -13,10 +12,6 @@ import { TokenCredential } from '@azure/core-auth';

// @public
export interface AlertConfigurationsPageResponse extends Array<AnomalyAlertConfiguration> {
_response: coreHttp.HttpResponse & {
bodyAsText: string;
parsedBody: any;
};
}

// @public
Expand All @@ -25,19 +20,11 @@ export type AlertQueryTimeMode = "AnomalyTime" | "CreatedTime" | "ModifiedTime";
// @public
export interface AlertsPageResponse extends Array<AnomalyAlert> {
continuationToken?: string;
_response: coreHttp.HttpResponse & {
bodyAsText: string;
parsedBody: any;
};
}

// @public
export interface AnomaliesPageResponse extends Array<DataPointAnomaly> {
continuationToken?: string;
_response: coreHttp.HttpResponse & {
bodyAsText: string;
parsedBody: any;
};
}

// @public
Expand Down Expand Up @@ -232,10 +219,6 @@ export interface CreateDataFeedOptions extends OperationOptions {
// @public
export interface CredentialsPageResponse extends Array<DataSourceCredentialEntityUnion> {
continuationToken?: string;
_response: coreHttp.HttpResponse & {
bodyAsText: string;
parsedBody: any;
};
}

// @public
Expand Down Expand Up @@ -344,10 +327,6 @@ export type DataFeedSourcePatch = Partial<DataFeedSource> & {
// @public
export interface DataFeedsPageResponse extends Array<MetricsAdvisorDataFeed> {
continuationToken?: string;
_response: coreHttp.HttpResponse & {
bodyAsText: string;
parsedBody: any;
};
}

// @public
Expand Down Expand Up @@ -504,10 +483,6 @@ export interface DetectionConditionsCommonPatch {

// @public
export interface DetectionConfigurationsPageResponse extends Array<AnomalyDetectionConfiguration> {
_response: coreHttp.HttpResponse & {
bodyAsText: string;
parsedBody: any;
};
}

// @public
Expand All @@ -516,10 +491,6 @@ export type DimensionKey = Record<string, string>;
// @public
export interface DimensionValuesPageResponse extends Array<string> {
continuationToken?: string;
_response: coreHttp.HttpResponse & {
bodyAsText: string;
parsedBody: any;
};
}

// @public
Expand Down Expand Up @@ -553,71 +524,32 @@ export type FeedbackQueryTimeMode = "MetricTimestamp" | "FeedbackCreatedTime";
export type FeedbackType = "Anomaly" | "ChangePoint" | "Period" | "Comment";

// @public
export type GetAlertConfigResponse = AnomalyAlertConfiguration & {
_response: coreHttp.HttpResponse & {
bodyAsText: string;
parsedBody: any;
};
};
export type GetAlertConfigResponse = AnomalyAlertConfiguration;
Copy link
Copy Markdown
Member

@jeremymeng jeremymeng Jun 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note: if possible (without risking doc team's work), remove these response types and use result type directly.


// @public
export type GetDataFeedResponse = MetricsAdvisorDataFeed & {
_response: coreHttp.HttpResponse & {
bodyAsText: string;
parsedBody: any;
};
};
export type GetDataFeedResponse = MetricsAdvisorDataFeed;

// @public
export type GetDataSourceCredentialEntityResponse = DataSourceCredentialEntityUnion & {
_response: coreHttp.HttpResponse & {
bodyAsText: string;
parsedBody: any;
};
};
export type GetDataSourceCredentialEntityResponse = DataSourceCredentialEntityUnion;

// @public
export type GetDetectionConfigResponse = AnomalyDetectionConfiguration & {
_response: coreHttp.HttpResponse & {
bodyAsText: string;
parsedBody: any;
};
};
export type GetDetectionConfigResponse = AnomalyDetectionConfiguration;

// @public
export type GetFeedbackResponse = MetricFeedbackUnion & {
_response: coreHttp.HttpResponse & {
bodyAsText: string;
parsedBody: any;
};
};
export type GetFeedbackResponse = MetricFeedbackUnion;

// @public
export type GetHookResponse = NotificationHookUnion & {
_response: coreHttp.HttpResponse & {
bodyAsText: string;
parsedBody: any;
};
};
export type GetHookResponse = NotificationHookUnion;

// @public
export type GetIncidentRootCauseResponse = {
rootCauses: IncidentRootCause[];
_response: coreHttp.HttpResponse & {
bodyAsText: string;
parsedBody: any;
};
};

// @public
export type GetIngestionProgressResponse = {
readonly latestSuccessTimestamp?: number;
readonly latestActiveTimestamp?: number;
} & {
_response: coreHttp.HttpResponse & {
bodyAsText: string;
parsedBody: any;
};
};

// @public
Expand All @@ -626,10 +558,6 @@ export interface GetMetricEnrichedSeriesDataOptions extends OperationOptions {

// @public
export interface GetMetricEnrichedSeriesDataResponse extends Array<MetricEnrichedSeriesData> {
_response: coreHttp.HttpResponse & {
bodyAsText: string;
parsedBody: any;
};
}

// @public
Expand All @@ -639,10 +567,6 @@ export interface GetMetricSeriesDataOptions extends OperationOptions {
// @public
export interface GetMetricSeriesDataResponse extends Array<MetricSeriesData> {
continuationToken?: string;
_response: coreHttp.HttpResponse & {
bodyAsText: string;
parsedBody: any;
};
}

// @public
Expand All @@ -664,10 +588,6 @@ export type HardThresholdConditionUnion = {
// @public
export interface HooksPageResponse extends Array<NotificationHookUnion> {
continuationToken?: string;
_response: coreHttp.HttpResponse & {
bodyAsText: string;
parsedBody: any;
};
}

// @public
Expand All @@ -681,10 +601,6 @@ export interface IncidentRootCause {
// @public
export interface IncidentsPageResponse extends Array<AnomalyIncident> {
continuationToken?: string;
_response: coreHttp.HttpResponse & {
bodyAsText: string;
parsedBody: any;
};
}

// @public
Expand All @@ -708,10 +624,6 @@ export interface IngestionStatus {
// @public
export interface IngestionStatusPageResponse extends Array<IngestionStatus> {
continuationToken?: string;
_response: coreHttp.HttpResponse & {
bodyAsText: string;
parsedBody: any;
};
}

// @public
Expand Down Expand Up @@ -928,10 +840,6 @@ export interface MetricEnrichedSeriesData {
// @public
export interface MetricEnrichmentStatusPageResponse extends Array<EnrichmentStatus> {
continuationToken?: string;
_response: coreHttp.HttpResponse & {
bodyAsText: string;
parsedBody: any;
};
}

// @public
Expand All @@ -946,10 +854,6 @@ export interface MetricFeedbackCommon {
// @public
export interface MetricFeedbackPageResponse extends Array<MetricFeedbackUnion> {
continuationToken?: string;
_response: coreHttp.HttpResponse & {
bodyAsText: string;
parsedBody: any;
};
}

// @public
Expand Down Expand Up @@ -1082,10 +986,6 @@ export type MetricSeriesGroupDetectionCondition = DetectionConditionsCommon & {
// @public
export interface MetricSeriesPageResponse extends Array<MetricSeriesDefinition> {
continuationToken?: string;
_response: coreHttp.HttpResponse & {
bodyAsText: string;
parsedBody: any;
};
}

// @public
Expand Down
Loading