remove _response from response types#16019
Merged
KarishmaGhiya merged 8 commits intomainfrom Jun 26, 2021
Merged
Conversation
ghost
added
the
KarishmaGhiya
changed the title
jeremymeng
reviewed
Jun 25, 2021
sdk/metricsadvisor/ai-metrics-advisor/src/metricsAdvisorAdministrationClient.ts
Outdated
Show resolved
Hide resolved
sdk/metricsadvisor/ai-metrics-advisor/src/metricsAdvisorAdministrationClient.ts
Outdated
Show resolved
Hide resolved
sdk/metricsadvisor/ai-metrics-advisor/src/metricsAdvisorAdministrationClient.ts
Outdated
Show resolved
Hide resolved
sdk/metricsadvisor/ai-metrics-advisor/src/metricsAdvisorAdministrationClient.ts
Outdated
Show resolved
Hide resolved
sdk/metricsadvisor/ai-metrics-advisor/src/metricsAdvisorAdministrationClient.ts
Outdated
Show resolved
Hide resolved
sdk/metricsadvisor/ai-metrics-advisor/src/metricsAdvisorAdministrationClient.ts
Outdated
Show resolved
Hide resolved
sdk/metricsadvisor/ai-metrics-advisor/src/metricsAdvisorClient.ts
Outdated
Show resolved
Hide resolved
jeremymeng
approved these changes
Jun 26, 2021
| parsedBody: any; | ||
| }; | ||
| }; | ||
| export type GetAlertConfigResponse = AnomalyAlertConfiguration; |
Member
There was a problem hiding this comment.
Just a note: if possible (without risking doc team's work), remove these response types and use result type directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove _response from the returned response types