[core] - Bump core-http to 2.0.0 and core-lro to 2.0.0 #15925
Conversation
ghost
added
Azure.Core
App Configuration
maorleger
requested review from
0rland0Wats0n,
DominikMe,
EmmaZhu,
HarshaNalluru,
KarishmaGhiya,
ankitarorabit,
chradek,
deyaaeldeen,
hectorhdzg,
jeremymeng,
jiacfan,
joheredi,
ljian3377,
ramya-rao-a and
richardpark-msft
as code owners
|
@maorleger can you add more details about what was the breaking change in core-tracing?, Azure Monitor Exporter is directly referencing OpenTelemetry packages and I want to be sure there will not be conflicts in there |
|
@maorleger In #15835, we talk about a different version bump for core-http. Should we perhaps do that first? |
|
@hectorhdzg sure! there are a few changes that matter:
My understanding is that we want to mirror OTel's interfaces so those changes carried over to us. @ramya-rao-a - good question. I don't know what we should do here - if it's all the same to you I'd rather defer to you @chradek @jeremymeng or @xirzec on this question |
|
@ramya-rao-a I chatted with @xirzec offline and we can bump the major to 2.0 for core-http @deyaaeldeen do you think you can land #15835 before the code freeze? Since we're already bumping the major version this would be the time to get that in |
|
@maorleger I will take a look now. |
maorleger
changed the title
|
@maorleger I believe #15835 is ready now to get merged soon. |
|
@EmmaZhu fyi - could I get storage folks to approve as well? |
jeremymeng
added
the
Client
maorleger
force-pushed
the
everyone-on-core-http-127
branch
from
a47ebbc to
4216c79
Compare
maorleger
changed the title
maorleger
force-pushed
the
everyone-on-core-http-127
branch
from
4216c79 to
01ea003
Compare
|
Known issue in test-utils which should be fixed by #15899 - the tests are all passing just the copy package step fails |
|
/check-enforcer override Edit: overriding because the only error is the known and unrelated test-utils failure which will be fixed by #15899 - the tests all pass |
…blob (#16182) We recently discovered an issue caused by bumping core-http by a major version (#15925) where if a transitive dependency is still allowing an older version we would end up with two versions of core-http / core-lro. This is a problem for two reasons: - bundle size - incompatibility of enums between two versions This was discovered via failed nightly tests and while some of this was fixed by #16180, we still need to audit all the packages and ensure that: For every package that moved to [email protected], all other dependencies of that package are pinned to a min-version that also uses [email protected] Luckily that is a very small number of packages - mainly communication (fixed) and storage (this PR)
8 participants
What
Why
This will support our last breaking change for core-tracing, and allow everyone to be on the same minimum version. This will also allow us to target ES2017 across the board.