[core] - GA core-rest-pipeline 1.1.0 #15923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maorleger
requested review from
EmmaZhu,
LarryOsterman,
XiaoningLiu,
YoDaMa,
chradek,
deyaaeldeen,
ellismg,
jeremymeng,
jiacfan,
joheredi,
ljian3377,
ramya-rao-a,
sadasant,
southpolesteve,
vinjiang,
witemple-msft,
xirzec and
zfoster
as code owners
ghost
added
Cosmos
Event Grid
KeyVault
Storage
ramya-rao-a
reviewed
Jun 23, 2021
| "@azure/core-auth": "^1.3.0", | ||
| "@azure-rest/core-client": "1.0.0-beta.4", | ||
| "@azure/core-rest-pipeline": "^1.0.3", | ||
| "@azure/core-rest-pipeline": "^1.1.0", |
Contributor
There was a problem hiding this comment.
This is a REST level client and so this file is auto generated. Therefore, we should update the code gen as well. Can we get an issue logged at https://github.com/Azure/autorest.typescript/issues
Contributor
There was a problem hiding this comment.
Or you could pile on to Azure/autorest.typescript#1048
cc @sarangan12
Member
Author
|
@southpolesteve @zfoster looks like the cosmos emulator has failed to start on multiple runs. Is that a known issue? |
Contributor
|
yeah, @jeremymeng asked me to take a look and I said I can end of this week |
Member
Author
ramya-rao-a
approved these changes
Jun 23, 2021
jeremymeng
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
@azure/core-rest-pipelineto 1.1.0 from beta@azure/core-tracingWhy
Now that we used the CAE capabilities added in core-rest-pipeline in both container registry and key vault it's time to GA this version! It also unblocks our efforts to get everyone upgraded to the latest core-tracing (and OTel by extension) versions.