[core] - GA core-rest-pipeline 1.1.0 (#15923)

maorleger · web-flow · commit 99d53b6b85e8 · 2021-06-23T13:49:36.000-07:00
## What

- Update `@azure/core-rest-pipeline` to 1.1.0 from beta
- Update dependencies to the latest version
- Update everyone to the same version of `@azure/core-tracing`

## Why

Now that we used the CAE capabilities added in core-rest-pipeline in both container registry and key vault it's time to GA this version! It also unblocks our efforts to get everyone upgraded to the latest core-tracing (and OTel by extension) versions.
diff --git a/common/config/rush/common-versions.json b/common/config/rush/common-versions.json
@@ -65,16 +65,14 @@
     // @azure/test-utils-perfstress should depend on lowest version of @azure/core-http for maximum compatibility, allowing test
     // projects to choose a higher version if desired.
     "@azure/core-http": ["^1.0.0"],
-    // @azure/container-registry and perf test are using the beta version in the repo.
-    "@azure/core-rest-pipeline": ["1.1.0-beta.4"],
     // @azure/event-processor-host is on a much lower major version
     "@azure/ms-rest-nodeauth": ["^0.9.2"],
     // Idenity is moving from v1 to v2. Moving all packages to v2 is going to take a bit of time, in the mean time we could use v2 on the perf-identity tests.
     "@azure/identity": ["^2.0.0-beta.4", "2.0.0-beta.3", "^1.1.0"],
     // Issue #14771 tracks updating to these versions
     "@microsoft/api-extractor": ["7.13.2"],
     "prettier": ["2.2.1"],
-    // All packages should move to 1.0.0 once core-rest-pipeline 1.1.0 GAs
-    "@azure/core-tracing": ["1.0.0-preview.11"]
+    // @azure/cosmos was unable to upgrade due to test failures, Issue #15928 tracks making this upgrade
+    "@azure/core-rest-pipeline": ["^1.0.3"]
   }
 }
diff --git a/sdk/agrifood/agrifood-farming-rest/package.json b/sdk/agrifood/agrifood-farming-rest/package.json
@@ -86,7 +86,7 @@
   "dependencies": {
     "@azure/core-auth": "^1.3.0",
     "@azure-rest/core-client": "1.0.0-beta.4",
-    "@azure/core-rest-pipeline": "^1.0.3",
+    "@azure/core-rest-pipeline": "^1.1.0",
     "@azure/logger": "^1.0.0",
     "tslib": "^2.2.0"
   },
diff --git a/sdk/attestation/attestation/package.json b/sdk/attestation/attestation/package.json
@@ -89,8 +89,8 @@
   "dependencies": {
     "@azure/core-auth": "^1.3.0",
     "@azure/core-client": "^1.0.0",
-    "@azure/core-rest-pipeline": "^1.0.3",
-    "@azure/core-tracing": "1.0.0-preview.11",
+    "@azure/core-rest-pipeline": "^1.1.0",
+    "@azure/core-tracing": "1.0.0-preview.12",
     "@azure/logger": "^1.0.0",
     "tslib": "^2.2.0",
     "jsrsasign": "^10.3.0"
diff --git a/sdk/confidentialledger/confidential-ledger-rest/package.json b/sdk/confidentialledger/confidential-ledger-rest/package.json
@@ -86,7 +86,7 @@
   "dependencies": {
     "@azure/core-auth": "^1.3.0",
     "@azure-rest/core-client": "1.0.0-beta.4",
-    "@azure/core-rest-pipeline": "^1.0.3",
+    "@azure/core-rest-pipeline": "^1.1.0",
     "@azure/logger": "^1.0.0",
     "tslib": "^2.2.0"
   },
diff --git a/sdk/containerregistry/container-registry/package.json b/sdk/containerregistry/container-registry/package.json
@@ -78,9 +78,9 @@
   "dependencies": {
     "@azure/core-auth": "^1.3.0",
     "@azure/core-client": "^1.0.0",
-    "@azure/core-rest-pipeline": "1.1.0-beta.4",
+    "@azure/core-rest-pipeline": "^1.1.0",
     "@azure/core-paging": "^1.1.1",
-    "@azure/core-tracing": "1.0.0-preview.11",
+    "@azure/core-tracing": "1.0.0-preview.12",
     "@azure/logger": "^1.0.0",
     "tslib": "^2.2.0"
   },
diff --git a/sdk/core/core-client-rest/package.json b/sdk/core/core-client-rest/package.json
@@ -62,7 +62,7 @@
   "prettier": "@azure/eslint-plugin-azure-sdk/prettier.json",
   "dependencies": {
     "@azure/core-auth": "^1.3.0",
-    "@azure/core-rest-pipeline": "^1.0.3",
+    "@azure/core-rest-pipeline": "^1.1.0",
     "tslib": "^2.2.0"
   },
   "devDependencies": {
diff --git a/sdk/core/core-client/package.json b/sdk/core/core-client/package.json
@@ -79,8 +79,8 @@
     "@azure/abort-controller": "^1.0.0",
     "@azure/core-asynciterator-polyfill": "^1.0.0",
     "@azure/core-auth": "^1.3.0",
-    "@azure/core-rest-pipeline": "^1.0.3",
-    "@azure/core-tracing": "1.0.0-preview.11",
+    "@azure/core-rest-pipeline": "^1.1.0",
+    "@azure/core-tracing": "1.0.0-preview.12",
     "tslib": "^2.2.0"
   },
   "devDependencies": {
diff --git a/sdk/core/core-rest-pipeline/CHANGELOG.md b/sdk/core/core-rest-pipeline/CHANGELOG.md
@@ -1,11 +1,15 @@
 # Release History
 
-## 1.1.0-beta.4 (Unreleased)
+## 1.1.0 (Unreleased)
 
 ### Fixed
 
 - Fixed an issue where `proxySettings` does not work when there is username but no password [Issue 15720](https://github.com/Azure/azure-sdk-for-js/issues/15720)
 
+### Breaking Changes
+
+- Updated @azure/core-tracing to version `1.0.0-preview.12`. See [@azure/core-tracing CHANGELOG](https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/core/core-tracing/CHANGELOG.md) for details about breaking changes with tracing.
+
 ## 1.1.0-beta.3 (2021-06-03)
 
 - Merged `bearerTokenChallengeAuthenticationPolicy` into `bearerTokenAuthenticationPolicy`. This will keep the functionality of `bearerTokenAuthenticationPolicy`, but also adds the `challengeCallbacks` feature.
diff --git a/sdk/core/core-rest-pipeline/package.json b/sdk/core/core-rest-pipeline/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@azure/core-rest-pipeline",
-  "version": "1.1.0-beta.4",
+  "version": "1.1.0",
   "description": "Isomorphic client library for making HTTP requests in node.js and browser.",
   "sdk-type": "client",
   "main": "dist/index.js",
@@ -93,7 +93,7 @@
   "dependencies": {
     "@azure/abort-controller": "^1.0.0",
     "@azure/core-auth": "^1.3.0",
-    "@azure/core-tracing": "1.0.0-preview.11",
+    "@azure/core-tracing": "1.0.0-preview.12",
     "@azure/logger": "^1.0.0",
     "form-data": "^3.0.0",
     "tslib": "^2.2.0",
diff --git a/sdk/core/core-rest-pipeline/src/constants.ts b/sdk/core/core-rest-pipeline/src/constants.ts
@@ -1,4 +1,4 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-export const SDK_VERSION: string = "1.1.0-beta.4";
+export const SDK_VERSION: string = "1.1.0";
diff --git a/sdk/core/core-rest-pipeline/src/policies/tracingPolicy.ts b/sdk/core/core-rest-pipeline/src/policies/tracingPolicy.ts
@@ -77,7 +77,7 @@ export function tracingPolicy(options: TracingPolicyOptions = {}): PipelinePolic
 
       try {
         // set headers
-        const spanContext = span.context();
+        const spanContext = span.spanContext();
         const traceParentHeader = getTraceParentHeader(spanContext);
         if (traceParentHeader) {
           request.headers.set("traceparent", traceParentHeader);
diff --git a/sdk/core/core-rest-pipeline/test/tracingPolicy.spec.ts b/sdk/core/core-rest-pipeline/test/tracingPolicy.spec.ts
@@ -88,7 +88,7 @@ class MockSpan implements Span {
     return this._attributes[key];
   }
 
-  context(): SpanContext {
+  spanContext(): SpanContext {
     const state = this.state;
 
     const traceState = {
diff --git a/sdk/core/perf-tests/core-rest-pipeline/package.json b/sdk/core/perf-tests/core-rest-pipeline/package.json
@@ -7,7 +7,7 @@
   "author": "",
   "license": "ISC",
   "dependencies": {
-    "@azure/core-rest-pipeline": "1.1.0-beta.4",
+    "@azure/core-rest-pipeline": "^1.1.0",
     "@azure/core-auth": "^1.3.0",
     "@azure/test-utils-perfstress": "^1.0.0",
     "dotenv": "^8.2.0"
diff --git a/sdk/documenttranslator/ai-document-translator-rest/package.json b/sdk/documenttranslator/ai-document-translator-rest/package.json
@@ -91,7 +91,7 @@
   "dependencies": {
     "@azure/core-auth": "^1.3.0",
     "@azure-rest/core-client": "1.0.0-beta.4",
-    "@azure/core-rest-pipeline": "^1.0.3",
+    "@azure/core-rest-pipeline": "^1.1.0",
     "@azure/logger": "^1.0.0",
     "tslib": "^2.2.0"
   },
diff --git a/sdk/eventgrid/eventgrid/package.json b/sdk/eventgrid/eventgrid/package.json
@@ -91,8 +91,8 @@
   "dependencies": {
     "@azure/core-auth": "^1.3.0",
     "@azure/core-client": "^1.0.0",
-    "@azure/core-rest-pipeline": "^1.0.3",
-    "@azure/core-tracing": "1.0.0-preview.11",
+    "@azure/core-rest-pipeline": "^1.1.0",
+    "@azure/core-tracing": "1.0.0-preview.12",
     "@azure/logger": "^1.0.0",
     "tslib": "^2.2.0",
     "uuid": "^8.3.0"
diff --git a/sdk/iot/iot-modelsrepository/package.json b/sdk/iot/iot-modelsrepository/package.json
@@ -66,8 +66,8 @@
   "dependencies": {
     "@azure/core-client": "^1.0.0",
     "@azure/core-util": "^1.0.0-beta.1",
-    "@azure/core-rest-pipeline": "^1.0.3",
-    "@azure/core-tracing": "1.0.0-preview.11",
+    "@azure/core-rest-pipeline": "^1.1.0",
+    "@azure/core-tracing": "1.0.0-preview.12",
     "@azure/logger": "^1.0.0",
     "events": "^3.0.0",
     "tslib": "^2.2.0"
diff --git a/sdk/keyvault/keyvault-admin/package.json b/sdk/keyvault/keyvault-admin/package.json
@@ -109,8 +109,8 @@
     "@azure/core-http": "^1.2.0",
     "@azure/core-lro": "^1.0.6",
     "@azure/core-paging": "^1.1.1",
-    "@azure/core-rest-pipeline": "1.1.0-beta.4",
-    "@azure/core-tracing": "1.0.0-preview.11",
+    "@azure/core-rest-pipeline": "^1.1.0",
+    "@azure/core-tracing": "1.0.0-preview.12",
     "@azure/logger": "^1.0.0",
     "@types/uuid": "^8.0.0",
     "tslib": "^2.2.0",
diff --git a/sdk/keyvault/keyvault-admin/test/utils/supportsTracing.ts b/sdk/keyvault/keyvault-admin/test/utils/supportsTracing.ts
@@ -34,7 +34,7 @@ export async function supportsTracing(
 
   // Ensure top-level children are created correctly.
   // Testing the entire tree structure can be tricky as other packages might create their own spans.
-  const spanGraph = tracer.getSpanGraph(rootSpan.context().traceId);
+  const spanGraph = tracer.getSpanGraph(rootSpan.spanContext().traceId);
   const directChildren = spanGraph.roots[0].children.map((child) => child.name);
   // LROs might poll N times, so we'll make a unique array and compare that.
   assert.sameMembers(Array.from(new Set(directChildren)), children);
diff --git a/sdk/purview/purview-catalog-rest/package.json b/sdk/purview/purview-catalog-rest/package.json
@@ -85,7 +85,7 @@
   "dependencies": {
     "@azure/core-auth": "^1.3.0",
     "@azure-rest/core-client": "1.0.0-beta.4",
-    "@azure/core-rest-pipeline": "^1.0.3",
+    "@azure/core-rest-pipeline": "^1.1.0",
     "@azure/logger": "^1.0.0",
     "tslib": "^2.2.0"
   },
diff --git a/sdk/purview/purview-scanning-rest/package.json b/sdk/purview/purview-scanning-rest/package.json
@@ -85,7 +85,7 @@
   "dependencies": {
     "@azure/core-auth": "^1.3.0",
     "@azure-rest/core-client": "1.0.0-beta.4",
-    "@azure/core-rest-pipeline": "^1.0.3",
+    "@azure/core-rest-pipeline": "^1.1.0",
     "@azure/logger": "^1.0.0",
     "tslib": "^2.2.0"
   },
diff --git a/sdk/storage/perf-tests/storage-blob/package.json b/sdk/storage/perf-tests/storage-blob/package.json
@@ -8,7 +8,7 @@
   "license": "ISC",
   "dependencies": {
     "@azure/core-http": "^1.2.0",
-    "@azure/core-rest-pipeline": "^1.0.3",
+    "@azure/core-rest-pipeline": "^1.1.0",
     "@azure/storage-blob": "^12.6.0-beta.1",
     "@azure/test-utils-perfstress": "^1.0.0",
     "dotenv": "^8.2.0",
diff --git a/sdk/storage/storage-blob/package.json b/sdk/storage/storage-blob/package.json
@@ -136,7 +136,7 @@
     "tslib": "^2.2.0"
   },
   "devDependencies": {
-    "@azure/core-rest-pipeline": "^1.0.3",
+    "@azure/core-rest-pipeline": "^1.1.0",
     "@azure/dev-tool": "^1.0.0",
     "@azure/eslint-plugin-azure-sdk": "^3.0.0",
     "@azure/identity": "2.0.0-beta.4",
diff --git a/sdk/tables/data-tables/package.json b/sdk/tables/data-tables/package.json
@@ -78,11 +78,11 @@
   "dependencies": {
     "@azure/core-auth": "^1.3.0",
     "@azure/core-client": "^1.0.0",
-    "@azure/core-rest-pipeline": "^1.0.3",
+    "@azure/core-rest-pipeline": "^1.1.0",
     "@azure/core-paging": "^1.1.1",
     "@azure/core-xml": "1.0.0-beta.1",
     "@azure/logger": "^1.0.0",
-    "@azure/core-tracing": "1.0.0-preview.11",
+    "@azure/core-tracing": "1.0.0-preview.12",
     "tslib": "^2.2.0",
     "uuid": "^8.3.0"
   },
diff --git a/sdk/textanalytics/ai-text-analytics/package.json b/sdk/textanalytics/ai-text-analytics/package.json
@@ -93,10 +93,10 @@
     "@azure/core-asynciterator-polyfill": "^1.0.0",
     "@azure/core-auth": "^1.3.0",
     "@azure/core-client": "^1.0.0",
-    "@azure/core-rest-pipeline": "^1.0.3",
+    "@azure/core-rest-pipeline": "^1.1.0",
     "@azure/core-lro": "^1.0.6",
     "@azure/core-paging": "^1.1.1",
-    "@azure/core-tracing": "1.0.0-preview.11",
+    "@azure/core-tracing": "1.0.0-preview.12",
     "@azure/logger": "^1.0.0",
     "tslib": "^2.2.0"
   },
