Conversation
This comment has been minimized.
This comment has been minimized.
|
Hmmm pipeline errors got me for a bit, but I think I have them under control. |
|
|
||
| constructor() { | ||
| super(); | ||
| this.credential = new DeviceCodeCredential({ |
There was a problem hiding this comment.
replace this with Client Secret Credential so that it is easy to automate.
There was a problem hiding this comment.
Can do! Anything else?
There was a problem hiding this comment.
nope, all fine otherwise, as long as perf test compiles and runs.
There was a problem hiding this comment.
@g2vinay the test does compile and run, but we can't make this run on CI because we currently can't have @azure/msal-node-extensions@1.0.0-alpha.6 as a dependency, at the moment 😵
There was a problem hiding this comment.
Now I'm using ClientSecretCredential :)
| **Important:** | ||
| These tests won't work on Node 8 nor Node 15. | ||
|
|
||
| 1. Install `@azure/msal-node-extensions@1.0.0-alpha.6` globally with `npm i -g @azure/msal-node-extensions@1.0.0-alpha.6`. |
There was a problem hiding this comment.
Why global?.. Is it not enough to add it as a dependency in the package.json?
There was a problem hiding this comment.
We can't have this dependency in our package.json since this means developers need to have Visual Studio or build-essential installed, and in some Node versions this dependency doesn't compile. We're working on it with the MSAL team.
There was a problem hiding this comment.
I meant.. dependency of the perf-test identity project, where you're mentioning @azure/identity.
sdk/identity/perf-tests/identity/test/ClientSecretCredential/persistence.spec.ts
Outdated
Show resolved
Hide resolved
sdk/identity/perf-tests/identity/test/ClientSecretCredential/persistence.spec.ts
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| async globalSetup(): Promise<void> { | ||
| await this.credential.getToken(scope); |
There was a problem hiding this comment.
why is this needed as a setup step?
There was a problem hiding this comment.
This initial call "caches" the token.
|
Hello @sadasant! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
This PR adds the package
@azure-tests/perf-identityand a first performance test for Identity.Here's the output from one run I did locally:
I used Key Vault Keys as a reference to write these files: https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/keyvault/perf-tests/keyvault-keys
As far as I could tell form Java's PR (link) the two goals for the Identity performance tests at the moment are:
Let me know how it looks! Any feedback appreciated.
Fixes #14632