Add Bearer Token Challenge Auth Policy performance test. #19360
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 22, 2021 08:10
g2vinay
changed the title
added 3 commits
February 22, 2021 08:12
g2vinay
requested review from
alzimmermsft,
anuchandy,
hemanttanwar,
jianghaolu,
schaabs and
srnagar
as code owners
srnagar
approved these changes
Mar 23, 2021
| /** | ||
| * The Performance Test class for Bearer Token Authentication Challenge Policy. | ||
| */ | ||
| public class ARMChallengeAuthenticationPolicyTest extends PerfStressTest<PerfStressOptions> { |
Member
There was a problem hiding this comment.
Why is this named ARM? This isn't related to the management plane right?
Member
Author
There was a problem hiding this comment.
Yes, this policy is for ARM SDK.
We will work with ARM folks and move it there later on.
added 2 commits
March 24, 2021 12:27
g2vinay
requested review from
JimSuplizio,
danieljurek,
mitchdenny and
samvaity
as code owners
added 4 commits
March 24, 2021 12:33
schaabs
approved these changes
Mar 25, 2021
This was referenced Mar 31, 2021
ghost
pushed a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
Apr 1, 2021
This PR adds the package `@azure-tests/perf-identity` and a first performance test for Identity. Here's the output from one run I did locally: ``` === Calling globalSetup() once for (all) the instance(s) of ClientSecretCredentialPersistenceTest === === warmup mode, iteration 0. Logs every 1s === Current Total Average 1589 1589 1590.49 === warmup mode, results of iteration 1 === Completed 1,591 operations in a weighted-average of 1.00s (1,589.46 ops/s, 0.001 s/op) === test mode, iteration 0. Logs every 1s === Current Total Average credential?: ClientSecretCredential; 2439 2439 2442.35 3036 5475 2739.85 3080 8555 2856.42 2789 11344 2820.61 3186 14530 2893.90 3110 17640 2927.82 3258 20898 2973.09 2981 23879 2974.87 3188 27067 2997.42 === test mode, results of iteration 1 === Completed 30,051 operations in a weighted-average of 10.00s (3,005.92 ops/s, 0.000 s/op) ``` I used Key Vault Keys as a reference to write these files: https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/keyvault/perf-tests/keyvault-keys As far as I could tell form Java's PR ([link](Azure/azure-sdk-for-java#19360)) the two goals for the Identity performance tests at the moment are: 1. Testing the challenge processing features on core, for which I have made a separate issue, since this feature is not yet in our main branch: #14633 . - The separation will also help reduce the number of changes to see when that perf test comes, since this one will have added all of the necessary files and folders around. 2. Testing the persistence feature, which this PR includes. Let me know how it looks! Any feedback appreciated. Fixes #14632
ghost
added
the
no-recent-activity
|
Hi @g2vinay. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
ghost
closed this
|
Hi @g2vinay. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Performance Test for Bearer Token Challenge Auth Policy and for the Token Caching API in Identity SDK,
Follows this flow for the Challenge Authentication policy performance test.
Follows this flow for the Token Caching API performance test.