Skip to content

Update TypeScript version to use ~ #14387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2 commits merged into from
Mar 22, 2021
Merged

Update TypeScript version to use ~ #14387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8b619b
Update TypeScript version to use ~
deyaaeldeen Mar 19, 2021
02e59d0
update typescript when not used as a devDependency
deyaaeldeen Mar 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions common/tools/dev-tool/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
"minimist": "~1.2.5",
"prettier": "^1.16.4",
"ts-node": "^8.3.0",
"typescript": "4.1.2"
"typescript": "~4.1.2"
},
"devDependencies": {
"@azure/eslint-plugin-azure-sdk": "^3.0.0",
Expand All @@ -69,6 +69,7 @@
"rollup": "^1.16.3",
"rollup-plugin-sourcemaps": "^0.4.2",
"rollup-plugin-visualizer": "^4.0.4",
"typedoc": "0.15.2"
"typedoc": "0.15.2",
"typescript": "~4.1.2"
Copy link
Member Author

@deyaaeldeen deyaaeldeen Mar 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@witemple-msft this is a duplication (similar to what we have in the eslint plugin) but it should be fine.

Copy link
Member

@witemple-msft witemple-msft Mar 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't doubt there's no issue with it, but is there a reason to keep it in both places?

Copy link
Member Author

@deyaaeldeen deyaaeldeen Mar 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No technical reason. I just like to keep the distinction between dependencies and devDependencies, TypeScript is needed as a package and also is needed as a tool to build in this case. If in the future we no longer need it as an imported package, we can remove its entry from dependencies and still have the devDependencies one for building.

Copy link
Member

@xirzec xirzec Mar 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels odd to me too, but I don't think it'll hurt anything?

}
}
4 changes: 2 additions & 2 deletions common/tools/eslint-plugin-azure-sdk/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
"eslint-config-prettier": "^7.0.0",
"glob": "^7.1.2",
"json-schema": "^0.3.0",
"typescript": "4.1.2",
"typescript": "~4.1.2",
"tslib": "^2.0.0"
},
"devDependencies": {
Expand All @@ -93,7 +93,7 @@
"rimraf": "^3.0.0",
"source-map-support": "^0.5.9",
"mocha-junit-reporter": "^1.18.0",
"typescript": "4.1.2",
"typescript": "~4.1.2",
"typedoc": "0.15.2"
}
}
2 changes: 1 addition & 1 deletion sdk/anomalydetector/ai-anomaly-detector/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@
"rollup-plugin-sourcemaps": "^0.4.2",
"rollup-plugin-terser": "^5.1.1",
"rollup-plugin-visualizer": "^4.0.4",
"typescript": "4.1.2",
"typescript": "~4.1.2",
"util": "^0.12.1",
"@azure/test-utils-recorder": "^1.0.0",
"typedoc": "0.15.2"
Expand Down
2 changes: 1 addition & 1 deletion sdk/appconfiguration/app-configuration/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@
"rollup-plugin-terser": "^5.1.1",
"sinon": "^9.0.2",
"ts-node": "^8.3.0",
"typescript": "4.1.2",
"typescript": "~4.1.2",
"uglify-js": "^3.4.9",
"cross-env": "^7.0.2",
"typedoc": "0.15.2"
Expand Down
2 changes: 1 addition & 1 deletion sdk/attestation/attestation/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
"rollup-plugin-sourcemaps": "^0.4.2",
"safe-buffer": "^5.2.1",
"ts-node": "^8.3.0",
"typescript": "4.1.2",
"typescript": "~4.1.2",
"typedoc": "0.15.2"
},
"homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/attestation/attestation/README.md",
Expand Down
2 changes: 1 addition & 1 deletion sdk/communication/communication-administration/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@
"rollup-plugin-shim": "^1.0.0",
"rollup": "^1.16.3",
"sinon": "^9.0.2",
"typescript": "4.1.2",
"typescript": "~4.1.2",
"typedoc": "0.15.2"
},
"//sampleConfiguration": {
Expand Down
2 changes: 1 addition & 1 deletion sdk/communication/communication-chat/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@
"rollup-plugin-visualizer": "^4.0.4",
"rollup": "^1.16.3",
"sinon": "^9.0.2",
"typescript": "4.1.2",
"typescript": "~4.1.2",
"util": "^0.12.1",
"typedoc": "0.15.2"
}
Expand Down
2 changes: 1 addition & 1 deletion sdk/communication/communication-common/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@
"rollup-plugin-visualizer": "^4.0.4",
"rollup": "^1.16.3",
"sinon": "^9.0.2",
"typescript": "4.1.2",
"typescript": "~4.1.2",
"util": "^0.12.1",
"typedoc": "0.15.2"
}
Expand Down
2 changes: 1 addition & 1 deletion sdk/communication/communication-identity/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@
"rollup-plugin-shim": "^1.0.0",
"rollup": "^1.16.3",
"sinon": "^9.0.2",
"typescript": "4.1.2",
"typescript": "~4.1.2",
"typedoc": "0.15.2"
}
}
2 changes: 1 addition & 1 deletion sdk/communication/communication-phone-numbers/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@
"rollup-plugin-shim": "^1.0.0",
"rollup": "^1.16.3",
"sinon": "^9.0.2",
"typescript": "4.1.2",
"typescript": "~4.1.2",
"typedoc": "0.15.2"
},
"//sampleConfiguration": {
Expand Down
2 changes: 1 addition & 1 deletion sdk/communication/communication-sms/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@
"rollup-plugin-shim": "^1.0.0",
"rollup": "^1.16.3",
"sinon": "^9.0.2",
"typescript": "4.1.2",
"typescript": "~4.1.2",
"util": "^0.12.1",
"typedoc": "0.15.2"
},
Expand Down
2 changes: 1 addition & 1 deletion sdk/containerregistry/container-registry/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@
"rimraf": "^3.0.0",
"rollup": "^1.16.3",
"typedoc": "0.15.2",
"typescript": "4.1.2",
"typescript": "~4.1.2",
"util": "^0.12.1"
},
"//sampleConfiguration": {
Expand Down
2 changes: 1 addition & 1 deletion sdk/core/abort-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@
"rollup-plugin-sourcemaps": "^0.4.2",
"rollup-plugin-terser": "^5.1.1",
"ts-node": "^8.3.0",
"typescript": "4.1.2",
"typescript": "~4.1.2",
"typedoc": "0.15.2"
}
}
2 changes: 1 addition & 1 deletion sdk/core/core-amqp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@
"rollup-plugin-terser": "^5.1.1",
"sinon": "^9.0.2",
"ts-node": "^8.3.0",
"typescript": "4.1.2",
"typescript": "~4.1.2",
"ws": "^7.1.1",
"typedoc": "0.15.2"
}
Expand Down
2 changes: 1 addition & 1 deletion sdk/core/core-asynciterator-polyfill/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
"@types/node": "^8.0.0",
"eslint": "^7.15.0",
"prettier": "^1.16.4",
"typescript": "4.1.2",
"typescript": "~4.1.2",
"typedoc": "0.15.2"
}
}
2 changes: 1 addition & 1 deletion sdk/core/core-auth/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@
"rollup-plugin-sourcemaps": "^0.4.2",
"rollup-plugin-terser": "^5.1.1",
"rollup-plugin-visualizer": "^4.0.4",
"typescript": "4.1.2",
"typescript": "~4.1.2",
"util": "^0.12.1",
"typedoc": "0.15.2"
}
Expand Down
2 changes: 1 addition & 1 deletion sdk/core/core-client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@
"rollup-plugin-terser": "^5.1.1",
"rollup-plugin-visualizer": "^4.0.4",
"sinon": "^9.0.2",
"typescript": "4.1.2",
"typescript": "~4.1.2",
"util": "^0.12.1",
"typedoc": "0.15.2"
}
Expand Down
2 changes: 1 addition & 1 deletion sdk/core/core-crypto/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@
"rollup-plugin-sourcemaps": "^0.4.2",
"rollup-plugin-terser": "^5.1.1",
"sinon": "^9.0.2",
"typescript": "4.1.2",
"typescript": "~4.1.2",
"typedoc": "0.15.2"
}
}
2 changes: 1 addition & 1 deletion sdk/core/core-http/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@
"shx": "^0.3.2",
"sinon": "^9.0.2",
"ts-node": "^8.3.0",
"typescript": "4.1.2",
"typescript": "~4.1.2",
"uglify-js": "^3.4.9",
"xhr-mock": "^2.4.1",
"typedoc": "0.15.2"
Expand Down
2 changes: 1 addition & 1 deletion sdk/core/core-lro/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@
"rollup-plugin-terser": "^5.1.1",
"rollup-plugin-visualizer": "^4.0.4",
"ts-node": "^8.3.0",
"typescript": "4.1.2",
"typescript": "~4.1.2",
"uglify-js": "^3.4.9",
"typedoc": "0.15.2"
}
Expand Down
2 changes: 1 addition & 1 deletion sdk/core/core-paging/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@
"eslint": "^7.15.0",
"prettier": "^1.16.4",
"rimraf": "^3.0.0",
"typescript": "4.1.2",
"typescript": "~4.1.2",
"typedoc": "0.15.2"
}
}
2 changes: 1 addition & 1 deletion sdk/core/core-rest-pipeline/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@
"rollup-plugin-visualizer": "^4.0.4",
"sinon": "^9.0.2",
"source-map-support": "^0.5.9",
"typescript": "4.1.2",
"typescript": "~4.1.2",
"util": "^0.12.1",
"typedoc": "0.15.2"
}
Expand Down
2 changes: 1 addition & 1 deletion sdk/core/core-tracing/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@
"rollup-plugin-sourcemaps": "^0.4.2",
"rollup-plugin-terser": "^5.1.1",
"rollup-plugin-visualizer": "^4.0.4",
"typescript": "4.1.2",
"typescript": "~4.1.2",
"util": "^0.12.1",
"typedoc": "0.15.2",
"sinon": "^9.0.2",
Expand Down
2 changes: 1 addition & 1 deletion sdk/core/core-util/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@
"rollup-plugin-terser": "^5.1.1",
"rollup-plugin-visualizer": "^4.0.4",
"sinon": "^9.0.2",
"typescript": "4.1.2",
"typescript": "~4.1.2",
"util": "^0.12.1",
"typedoc": "0.15.2"
}
Expand Down
2 changes: 1 addition & 1 deletion sdk/core/core-xml/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@
"rollup-plugin-terser": "^5.1.1",
"rollup-plugin-visualizer": "^4.0.4",
"sinon": "^9.0.2",
"typescript": "4.1.2",
"typescript": "~4.1.2",
"util": "^0.12.1",
"typedoc": "0.15.2"
}
Expand Down
2 changes: 1 addition & 1 deletion sdk/core/logger/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@
"rollup-plugin-terser": "^5.1.1",
"sinon": "^9.0.2",
"ts-node": "^8.3.0",
"typescript": "4.1.2",
"typescript": "~4.1.2",
"typedoc": "0.15.2"
}
}
2 changes: 1 addition & 1 deletion sdk/cosmosdb/cosmos/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,6 @@
"source-map-support": "^0.5.9",
"ts-node": "^8.3.0",
"typedoc": "0.15.2",
"typescript": "4.1.2"
"typescript": "~4.1.2"
}
}
2 changes: 1 addition & 1 deletion sdk/deviceupdate/iot-device-update/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"rollup": "^1.16.3",
"source-map-support": "^0.5.9",
"typedoc": "0.15.2",
"typescript": "4.1.2",
"typescript": "~4.1.2",
"uglify-js": "^3.4.9",
"uuid": "^8.3.0"
},
Expand Down
2 changes: 1 addition & 1 deletion sdk/digitaltwins/digital-twins-core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@
"rollup-plugin-terser": "^5.1.1",
"rollup-plugin-visualizer": "^4.0.4",
"sinon": "^9.0.2",
"typescript": "4.1.2",
"typescript": "~4.1.2",
"util": "^0.12.1",
"typedoc": "0.15.2"
},
Expand Down
2 changes: 1 addition & 1 deletion sdk/eventgrid/eventgrid/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@
"sinon": "^9.0.2",
"source-map-support": "^0.5.9",
"ts-node": "^8.3.0",
"typescript": "4.1.2",
"typescript": "~4.1.2",
"typedoc": "0.15.2"
}
}
2 changes: 1 addition & 1 deletion sdk/eventgrid/perf-tests/eventgrid/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"rimraf": "^3.0.0",
"tslib": "^2.0.0",
"ts-node": "^8.3.0",
"typescript": "4.1.2"
"typescript": "~4.1.2"
},
"private": true,
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion sdk/eventhub/event-hubs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@
"rollup-plugin-terser": "^5.1.1",
"sinon": "^9.0.2",
"ts-node": "^8.3.0",
"typescript": "4.1.2",
"typescript": "~4.1.2",
"ws": "^7.1.1",
"typedoc": "0.15.2"
}
Expand Down
2 changes: 1 addition & 1 deletion sdk/eventhub/event-processor-host/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@
"rollup": "^1.16.3",
"rollup-plugin-sourcemaps": "^0.4.2",
"ts-node": "^8.3.0",
"typescript": "4.1.2",
"typescript": "~4.1.2",
"ws": "^7.1.1",
"typedoc": "0.15.2"
}
Expand Down
2 changes: 1 addition & 1 deletion sdk/eventhub/eventhubs-checkpointstore-blob/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@
"rollup-plugin-terser": "^5.1.1",
"rollup-plugin-visualizer": "^4.0.4",
"ts-node": "^8.3.0",
"typescript": "4.1.2",
"typescript": "~4.1.2",
"util": "^0.12.1",
"typedoc": "0.15.2"
},
Expand Down
2 changes: 1 addition & 1 deletion sdk/eventhub/mock-hub/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
"eslint": "^7.15.0",
"prettier": "^1.16.4",
"rimraf": "^3.0.0",
"typescript": "4.1.2"
"typescript": "~4.1.2"
},
"dependencies": {
"@azure/abort-controller": "^1.0.0",
Expand Down
12 changes: 6 additions & 6 deletions sdk/eventhub/testhub/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,20 +37,20 @@
"dependencies": {
"@azure/event-hubs": "^2.1.4",
"@azure/event-processor-host": "^2.0.0",
"@types/node": "^8.0.0",
"@types/uuid": "^8.0.0",
"@types/yargs": "^15.0.5",
"async-lock": "^1.1.3",
"death": "^1.1.0",
"debug": "^4.1.1",
"rhea": "^1.0.24",
"rimraf": "^3.0.0",
"tslib": "^2.0.0",
"typescript": "4.1.2",
Copy link
Member

@xirzec xirzec Mar 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

"uuid": "^8.3.0",
"yargs": "^15.0.0"
},
"devDependencies": {
"eslint": "^7.15.0"
"@types/node": "^8.0.0",
"@types/uuid": "^8.0.0",
"@types/yargs": "^15.0.5",
"eslint": "^7.15.0",
"rimraf": "^3.0.0",
"typescript": "~4.1.2"
}
}
2 changes: 1 addition & 1 deletion sdk/formrecognizer/ai-form-recognizer/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@
"rollup": "^1.16.3",
"sinon": "^9.0.2",
"source-map-support": "^0.5.9",
"typescript": "4.1.2",
"typescript": "~4.1.2",
"typedoc": "0.15.2"
},
"//sampleConfiguration": {
Expand Down
2 changes: 1 addition & 1 deletion sdk/identity/identity/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@
"rollup-plugin-sourcemaps": "^0.4.2",
"rollup-plugin-terser": "^5.1.1",
"rollup-plugin-visualizer": "^4.0.4",
"typescript": "4.1.2",
"typescript": "~4.1.2",
"util": "^0.12.1",
"sinon": "^9.0.2",
"@types/sinon": "^9.0.4",
Expand Down
2 changes: 1 addition & 1 deletion sdk/keyvault/keyvault-admin/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@
"rollup-plugin-visualizer": "^4.0.4",
"sinon": "^9.0.2",
"source-map-support": "^0.5.9",
"typescript": "4.1.2",
"typescript": "~4.1.2",
"uuid": "^8.3.0",
"typedoc": "0.15.2"
}
Expand Down
2 changes: 1 addition & 1 deletion sdk/keyvault/keyvault-certificates/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@
"rollup-plugin-visualizer": "^4.0.4",
"sinon": "^9.0.2",
"source-map-support": "^0.5.9",
"typescript": "4.1.2",
"typescript": "~4.1.2",
"url": "^0.11.0",
"typedoc": "0.15.2"
}
Expand Down
Loading