Update TypeScript version to use ~ #14387
Conversation
deyaaeldeen
requested review from
a team,
EmmaZhu,
HarshaNalluru,
KarishmaGhiya,
XiaoningLiu,
bterlson,
chradek,
daviwil,
ellismg,
hectorhdzg,
jeremymeng,
jiacfan,
joheredi,
ljian3377,
maorleger,
mikeharder,
praveenkuttappan,
ramya-rao-a,
richardpark-msft,
sadasant,
sarangan12,
schaabs,
southpolesteve,
vinjiang and
zfoster
as code owners
ghost
added
App Configuration
|
Hello @deyaaeldeen! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
| "rollup-plugin-visualizer": "^4.0.4", | ||
| "typedoc": "0.15.2" | ||
| "typedoc": "0.15.2", | ||
| "typescript": "~4.1.2" |
There was a problem hiding this comment.
@witemple-msft this is a duplication (similar to what we have in the eslint plugin) but it should be fine.
There was a problem hiding this comment.
I don't doubt there's no issue with it, but is there a reason to keep it in both places?
There was a problem hiding this comment.
No technical reason. I just like to keep the distinction between dependencies and devDependencies, TypeScript is needed as a package and also is needed as a tool to build in this case. If in the future we no longer need it as an imported package, we can remove its entry from dependencies and still have the devDependencies one for building.
There was a problem hiding this comment.
It feels odd to me too, but I don't think it'll hurt anything?
| "rhea": "^1.0.24", | ||
| "rimraf": "^3.0.0", | ||
| "tslib": "^2.0.0", | ||
| "typescript": "4.1.2", |
ghost
merged commit 
This PR adds back a missing condition during the refactoring in Azure#14387
4 participants
I confirmed with the TypeScript team that patch releases should not introduce breaking changes. This PR uses tilde in TypeScript version we use so get the latest patch releases for v4.1.