-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Upgrade V6 SDK Generator Version for Event Grid #13361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -122,36 +122,41 @@ export type AcsSmsReceivedEventData = AcsSmsEventBase & { | |
| }; | ||
|
|
||
| // @public | ||
| export type AppAction = "Restarted" | "Stopped" | "ChangedAppSettings" | "Started" | "Completed" | "Failed"; | ||
| export type AppAction = string; | ||
|
|
||
| // @public | ||
| export interface AppConfigurationKeyValueDeletedEventData { | ||
| etag?: string; | ||
| key?: string; | ||
| label?: string; | ||
| syncToken?: string; | ||
| } | ||
|
|
||
| // @public | ||
| export interface AppConfigurationKeyValueModifiedEventData { | ||
| etag?: string; | ||
| key?: string; | ||
| label?: string; | ||
| syncToken?: string; | ||
| } | ||
|
|
||
| // @public | ||
| export interface AppEventTypeDetail { | ||
| action?: AppAction; | ||
| } | ||
|
|
||
| // @public | ||
| export type AppServicePlanAction = string; | ||
|
|
||
| // @public | ||
| export interface AppServicePlanEventTypeDetail { | ||
| action?: "Updated"; | ||
| action?: AppServicePlanAction; | ||
| stampKind?: StampKind; | ||
| status?: AsyncStatus; | ||
| } | ||
|
|
||
| // @public | ||
| export type AsyncStatus = "Started" | "Completed" | "Failed"; | ||
| export type AsyncStatus = string; | ||
|
|
||
| export { AzureKeyCredential } | ||
|
|
||
|
|
@@ -347,7 +352,6 @@ export class EventGridPublisherClient { | |
| readonly endpointUrl: string; | ||
| sendCloudEvents(events: SendCloudEventInput<any>[], options?: SendCloudEventsOptions): Promise<SendEventsResponse>; | ||
| sendCustomSchemaEvents(events: Record<string, any>[], options?: SendCustomSchemaEventsOptions): Promise<SendEventsResponse>; | ||
| // Warning: (ae-forgotten-export) The symbol "SendEventsResponse" needs to be exported by the entry point index.d.ts | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This line of code change is not really related to Version Upgrade. I just found a forgotten export and added it. Please let me know if this is not exported intentionally. I can revert the changes. Thanks
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nope, this was just me forgetting to export something. Thank you for fixing! |
||
| sendEvents(events: SendEventGridEventInput<any>[], options?: SendEventsOptions): Promise<SendEventsResponse>; | ||
| } | ||
|
|
||
|
|
@@ -513,6 +517,35 @@ export interface KeyVaultSecretNewVersionCreatedEventData { | |
| version?: string; | ||
| } | ||
|
|
||
| // @public | ||
| export const enum KnownAppAction { | ||
| ChangedAppSettings = "ChangedAppSettings", | ||
| Completed = "Completed", | ||
| Failed = "Failed", | ||
| Restarted = "Restarted", | ||
| Started = "Started", | ||
| Stopped = "Stopped" | ||
| } | ||
|
|
||
| // @public | ||
| export const enum KnownAppServicePlanAction { | ||
| Updated = "Updated" | ||
| } | ||
|
|
||
| // @public | ||
| export const enum KnownAsyncStatus { | ||
| Completed = "Completed", | ||
| Failed = "Failed", | ||
| Started = "Started" | ||
| } | ||
|
|
||
| // @public | ||
| export const enum KnownStampKind { | ||
| AseV1 = "AseV1", | ||
| AseV2 = "AseV2", | ||
| Public = "Public" | ||
| } | ||
|
|
||
| // @public | ||
| export type KnownSystemEventTypes = "Microsoft.AppConfiguration.KeyValueDeleted" | "Microsoft.AppConfiguration.KeyValueModified" | "Microsoft.Communication.ChatMessageReceived" | "Microsoft.Communication.ChatMessageEdited" | "Microsoft.Communication.ChatMessageDeleted" | "Microsoft.Communication.ChatThreadCreatedWithUser" | "Microsoft.Communication.ChatThreadWithUserDeleted" | "Microsoft.Communication.ChatThreadPropertiesUpdatedPerUser" | "Microsoft.Communication.ChatMemberAddedToThreadWithUser" | "Microsoft.Communication.ChatMemberRemovedFromThreadWithUser" | "Microsoft.Communication.SMSDeliveryReportReceived" | "Microsoft.Communication.SMSReceived" | "Microsoft.ContainerRegistry.ImagePushed" | "Microsoft.ContainerRegistry.ImageDeleted" | "Microsoft.ContainerRegistry.ChartDeleted" | "Microsoft.ContainerRegistry.ChartPushed" | "Microsoft.Devices.DeviceCreated" | "Microsoft.Devices.DeviceDeleted" | "Microsoft.Devices.DeviceConnected" | "Microsoft.Devices.DeviceDisconnected" | "Microsoft.Devices.DeviceTelemetry" | "Microsoft.EventGrid.SubscriptionValidationEvent" | "Microsoft.EventGrid.SubscriptionDeletedEvent" | "Microsoft.EventHub.CaptureFileCreated" | "Microsoft.KeyVault.CertificateNewVersionCreated" | "Microsoft.KeyVault.CertificateNearExpiry" | "Microsoft.KeyVault.CertificateExpired" | "Microsoft.KeyVault.KeyNewVersionCreated" | "Microsoft.KeyVault.KeyNearExpiry" | "Microsoft.KeyVault.KeyExpired" | "Microsoft.KeyVault.SecretNewVersionCreated" | "Microsoft.KeyVault.SecretNearExpiry" | "Microsoft.KeyVault.SecretExpired" | "Microsoft.KeyVault.VaultAccessPolicyChanged" | "Microsoft.MachineLearningServices.DatasetDriftDetected" | "Microsoft.MachineLearningServices.ModelDeployed" | "Microsoft.MachineLearningServices.ModelRegistered" | "Microsoft.MachineLearningServices.RunCompleted" | "Microsoft.MachineLearningServices.RunStatusChanged" | "Microsoft.Maps.GeofenceEntered" | "Microsoft.Maps.GeofenceExited" | "Microsoft.Maps.GeofenceResult" | "Microsoft.Media.JobStateChange" | "Microsoft.Media.JobOutputStateChange" | "Microsoft.Media.JobScheduled" | "Microsoft.Media.JobProcessing" | "Microsoft.Media.JobCanceling" | "Microsoft.Media.JobFinished" | "Microsoft.Media.JobCanceled" | "Microsoft.Media.JobErrored" | "Microsoft.Media.JobOutputCanceled" | "Microsoft.Media.JobOutputCanceling" | "Microsoft.Media.JobOutputErrored" | "Microsoft.Media.JobOutputFinished" | "Microsoft.Media.JobOutputProcessing" | "Microsoft.Media.JobOutputScheduled" | "Microsoft.Media.JobOutputProgress" | "Microsoft.Media.LiveEventEncoderConnected" | "Microsoft.Media.LiveEventConnectionRejected" | "Microsoft.Media.LiveEventEncoderDisconnected" | "Microsoft.Media.LiveEventIncomingStreamReceived" | "Microsoft.Media.LiveEventIncomingStreamsOutOfSync" | "Microsoft.Media.LiveEventIncomingVideoStreamsOutOfSync" | "Microsoft.Media.LiveEventIncomingDataChunkDropped" | "Microsoft.Media.LiveEventIngestHeartbeat" | "Microsoft.Media.LiveEventTrackDiscontinuityDetected" | "Microsoft.Resources.ResourceWriteSuccess" | "Microsoft.Resources.ResourceWriteFailure" | "Microsoft.Resources.ResourceWriteCancel" | "Microsoft.Resources.ResourceDeleteSuccess" | "Microsoft.Resources.ResourceDeleteFailure" | "Microsoft.Resources.ResourceDeleteCancel" | "Microsoft.Resources.ResourceActionSuccess" | "Microsoft.Resources.ResourceActionFailure" | "Microsoft.Resources.ResourceActionCancel" | "Microsoft.ServiceBus.ActiveMessagesAvailableWithNoListeners" | "Microsoft.ServiceBus.DeadletterMessagesAvailableWithNoListener" | "Microsoft.Storage.BlobCreated" | "Microsoft.Storage.BlobDeleted" | "Microsoft.Storage.BlobRenamed" | "Microsoft.Storage.DirectoryCreated" | "Microsoft.Storage.DirectoryDeleted" | "Microsoft.Storage.DirectoryRenamed" | "Microsoft.Storage.LifecyclePolicyCompleted" | "Microsoft.Web.AppUpdated" | "Microsoft.Web.BackupOperationStarted" | "Microsoft.Web.BackupOperationCompleted" | "Microsoft.Web.BackupOperationFailed" | "Microsoft.Web.RestoreOperationStarted" | "Microsoft.Web.RestoreOperationCompleted" | "Microsoft.Web.RestoreOperationFailed" | "Microsoft.Web.SlotSwapStarted" | "Microsoft.Web.SlotSwapCompleted" | "Microsoft.Web.SlotSwapFailed" | "Microsoft.Web.SlotSwapWithPreviewStarted" | "Microsoft.Web.SlotSwapWithPreviewCancelled" | "Microsoft.Web.AppServicePlanUpdated"; | ||
|
|
||
|
|
@@ -634,16 +667,16 @@ export type MediaJobFinishedEventData = MediaJobStateChangeEventData & { | |
|
|
||
| // @public | ||
| export interface MediaJobOutput { | ||
| "@odata.type": "#Microsoft.Media.JobOutputAsset"; | ||
| error?: MediaJobError; | ||
| label?: string; | ||
| odataType?: string; | ||
| odataType: "#Microsoft.Media.JobOutputAsset"; | ||
| progress: number; | ||
| state: MediaJobState; | ||
| } | ||
|
|
||
| // @public | ||
| export type MediaJobOutputAsset = MediaJobOutput & { | ||
| odataType: "#Microsoft.Media.JobOutputAsset"; | ||
| assetName?: string; | ||
| }; | ||
|
|
||
|
|
@@ -970,6 +1003,11 @@ export interface SendEventGridEventInput<T> { | |
| // @public | ||
| export type SendEventsOptions = OperationOptions; | ||
|
|
||
| // @public | ||
| export interface SendEventsResponse { | ||
| _response: HttpResponse; | ||
| } | ||
|
|
||
| // @public | ||
| export interface ServiceBusActiveMessagesAvailableWithNoListenersEventData { | ||
| entityType?: string; | ||
|
|
@@ -996,7 +1034,7 @@ export interface SignatureCredential { | |
| } | ||
|
|
||
| // @public | ||
| export type StampKind = "Public" | "AseV1" | "AseV2"; | ||
| export type StampKind = string; | ||
|
|
||
| // @public | ||
| export interface StorageBlobCreatedEventData { | ||
|
|
@@ -1075,9 +1113,15 @@ export interface StorageDirectoryRenamedEventData { | |
| storageDiagnostics?: any; | ||
| } | ||
|
|
||
| // @public | ||
| export interface StorageLifecyclePolicyActionSummaryDetail { | ||
| errorList?: string; | ||
| successCount?: number; | ||
| totalObjectsCount?: number; | ||
| } | ||
|
|
||
| // @public | ||
| export interface StorageLifecyclePolicyCompletedEventData { | ||
| // Warning: (ae-forgotten-export) The symbol "StorageLifecyclePolicyActionSummaryDetail" needs to be exported by the entry point index.d.ts | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This line of code change is not really related to Version Upgrade. I just found a forgotten export and added it. Please let me know if this is not exported intentionally. I can revert the changes. Thanks |
||
| deleteSummary?: StorageLifecyclePolicyActionSummaryDetail; | ||
| scheduleTime?: string; | ||
| tierToArchiveSummary?: StorageLifecyclePolicyActionSummaryDetail; | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| /* | ||
| * Copyright (c) Microsoft Corporation. | ||
| * Licensed under the MIT License. | ||
| * | ||
| * Code generated by Microsoft (R) AutoRest Code Generator. | ||
| * Changes may cause incorrect behavior and will be lost if the code is regenerated. | ||
| */ | ||
|
|
||
| export * from "./models"; | ||
| export { GeneratedClient } from "./generatedClient"; | ||
| export { GeneratedClientContext } from "./generatedClientContext"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we have this new property?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was added with this commit: Azure/azure-rest-api-specs#11819 2 months back. The swagger is pointing to master branch. So, it is picking up new changes. The changes seemed minimal. So, I took them it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, this is not a breaking change since the new properties are optional, however I would like @ellismg to confirm if we want to start exposing these properties now. Other than this I think the changes look reasonable and all checks pass
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exposing these now is great!