Upgrade V6 SDK Generator Version for Event Grid#13361
Upgrade V6 SDK Generator Version for Event Grid#13361sarangan12 merged 1 commit intoAzure:masterfrom
Conversation
sarangan12
requested review from
bterlson,
chradek,
ellismg,
ramya-rao-a and
xirzec
as code owners
ghost
added
the
| readonly endpointUrl: string; | ||
| sendCloudEvents(events: SendCloudEventInput<any>[], options?: SendCloudEventsOptions): Promise<SendEventsResponse>; | ||
| sendCustomSchemaEvents(events: Record<string, any>[], options?: SendCustomSchemaEventsOptions): Promise<SendEventsResponse>; | ||
| // Warning: (ae-forgotten-export) The symbol "SendEventsResponse" needs to be exported by the entry point index.d.ts |
There was a problem hiding this comment.
This line of code change is not really related to Version Upgrade. I just found a forgotten export and added it. Please let me know if this is not exported intentionally. I can revert the changes. Thanks
There was a problem hiding this comment.
Nope, this was just me forgetting to export something. Thank you for fixing!
|
|
||
| // @public | ||
| export interface StorageLifecyclePolicyCompletedEventData { | ||
| // Warning: (ae-forgotten-export) The symbol "StorageLifecyclePolicyActionSummaryDetail" needs to be exported by the entry point index.d.ts |
There was a problem hiding this comment.
This line of code change is not really related to Version Upgrade. I just found a forgotten export and added it. Please let me know if this is not exported intentionally. I can revert the changes. Thanks
| /** | ||
| * The event data for a Job output asset. | ||
| */ | ||
| export type MediaJobOutputAsset = MediaJobOutput & { |
There was a problem hiding this comment.
Were there changes in the SWAGGER? I see this type has a new property odataType (below). Also saw a couple of other definitions with new properties
There was a problem hiding this comment.
No. These changes are due to the generator. In old generator, when we have the odata type only the base class has odata type defined (possibly with a union type). With the new generator, even the subclasses have their own odata types and the base class has its own odata type (mostly not used at all)
| etag?: string; | ||
| key?: string; | ||
| label?: string; | ||
| syncToken?: string; |
There was a problem hiding this comment.
Why do we have this new property?
There was a problem hiding this comment.
It was added with this commit: Azure/azure-rest-api-specs#11819 2 months back. The swagger is pointing to master branch. So, it is picking up new changes. The changes seemed minimal. So, I took them it
There was a problem hiding this comment.
Okay, this is not a breaking change since the new properties are optional, however I would like @ellismg to confirm if we want to start exposing these properties now. Other than this I think the changes look reasonable and all checks pass
ellismg
left a comment
ellismg
left a comment
There was a problem hiding this comment.
LGTM. Thank you for upgrading the generator!
| etag?: string; | ||
| key?: string; | ||
| label?: string; | ||
| syncToken?: string; |
3 participants
The last V6 SDK version that is used to generate Event Grid is 6.0.0-dev.20200618.1. This PR is to upgrade the V6 SDK version to the latest 6.0.0-dev.20210121.2 version.
@ellismg Please review and approve.
@joheredi @ramya-rao-a FYI.......