Clear expiredMessageSessions when reciever is created for the same session

packages/@azure/servicebus/data-plane/lib/queueClient.ts

@@ -177,10 +177,12 @@ export class QueueClient extends Client {
           } before using "getSessionReceiver" to create a new one for the same sessionId`
         );
       }
-      delete this._context.expiredMessageSessions[options.sessionId];
     }
     this._context.isSessionEnabled = true;
     const messageSession = await MessageSession.create(this._context, options);
+    if (messageSession.sessionId) {
+      delete this._context.expiredMessageSessions[messageSession.sessionId];
+    }
     return new SessionReceiver(this._context, messageSession);
   }
 }

packages/@azure/servicebus/data-plane/lib/subscriptionClient.ts

@@ -219,10 +219,12 @@ export class SubscriptionClient extends Client {
           } before using "getSessionReceiver" to create a new one for the same sessionId`
         );
       }
-      delete this._context.expiredMessageSessions[options.sessionId];
     }
     this._context.isSessionEnabled = true;
     const messageSession = await MessageSession.create(this._context, options);
+    if (messageSession.sessionId) {
+      delete this._context.expiredMessageSessions[messageSession.sessionId];
+    }
     return new SessionReceiver(this._context, messageSession);
   }
 

packages/@azure/servicebus/data-plane/test/renewLockSessions.spec.ts

@@ -440,8 +440,8 @@ async function testBatchReceiverManualLockRenewalErrorOnLockExpiry(
 
   should.equal(errorWasThrown, true, "Error thrown flag must be true");
 
-  // Clean up any left over messages
-  sessionClient = await receiverClient.getSessionReceiver({ sessionId: testSessionId1 });
+  // Subsequent receivers for the same session should work as expected.
+  sessionClient = await receiverClient.getSessionReceiver();
   const unprocessedMsgs = await sessionClient.receiveBatch(1);
   await unprocessedMsgs[0].complete();
 }