Clear expiredMessageSessions when reciever is created for the same session#1264
Merged
ramya-rao-a merged 3 commits intoAzure:masterfrom Feb 19, 2019
Merged
Clear expiredMessageSessions when reciever is created for the same session#1264ramya-rao-a merged 3 commits intoAzure:masterfrom
ramya-rao-a merged 3 commits intoAzure:masterfrom
Conversation
ghost
added
the
HarshaNalluru
pushed a commit
to HarshaNalluru/azure-sdk-for-js
that referenced
this pull request
Apr 12, 2019
…or the same session (Azure#1264)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1263 by clearing expiredMessageSessions regardless of whether sessionId was passed to
getSessionReceiveror not.One of the existing test cases are updated to cover the test for this case.