Skip to content

[Service Bus] Pick older core-http for service-bus preview.8 🏁 #12285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
3 commits merged into from
Nov 4, 2020
Merged

[Service Bus] Pick older core-http for service-bus preview.8 🏁 #12285

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9224807
pick older core-http for service-bus preview
HarshaNalluru Nov 4, 2020
323616e
allowedAlternativeVersions for core-http to release service-bus previ…
HarshaNalluru Nov 4, 2020
9d29592
core-http 1.1.9
HarshaNalluru Nov 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions common/config/rush/common-versions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,11 @@
* This design avoids unnecessary churn in this file.
*/
"allowedAlternativeVersions": {
/**
* Temporary workaround to release service-bus v7 preview.8.
* Supposed to be reverted after the release.
*/
"@azure/core-http": ["^1.1.6"],
"@azure/ms-rest-js": ["^2.0.0"],
/**
* For example, allow some projects to use an older TypeScript compiler
Expand Down
2 changes: 1 addition & 1 deletion sdk/servicebus/service-bus/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@
"@azure/abort-controller": "^1.0.0",
"@azure/core-amqp": "2.0.0-beta.1",
"@azure/core-asynciterator-polyfill": "^1.0.0",
"@azure/core-http": "^1.2.0",
"@azure/core-http": "^1.1.6",

@jeremymeng jeremymeng Nov 4, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we use the latest released 1.1.9?

@HarshaNalluru HarshaNalluru Nov 4, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, 1.1.6 was the last used version, and hence picked that.
I don't see a reason to not update to 1.1.9. Will do.

"@azure/core-tracing": "1.0.0-preview.9",
"@azure/core-paging": "^1.1.1",
"@azure/core-auth": "^1.1.3",
Expand Down