Skip to content

[storage] parallel upload refactor #12185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ljian3377 merged 4 commits into from
Nov 4, 2020
Merged

[storage] parallel upload refactor #12185

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
694f05b
uploadData for Node.js and browsers, refactor duplicated code
ljian3377 Oct 30, 2020
033754b
inline, changelog and add test case for browser
ljian3377 Nov 2, 2020
980ec2b
Merge branch 'master' into storage/upload-refactor
ljian3377 Nov 2, 2020
2f1c118
nit: comments
ljian3377 Nov 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/storage/storage-blob/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ There are differences between Node.js and browsers runtime. When getting started
- Shared Access Signature(SAS) generation
- `generateAccountSASQueryParameters()`
- `generateBlobSASQueryParameters()`
- Parallel uploading and downloading
- Parallel uploading and downloading. Note that `BlockBlobClient.uploadData()` is available in both Node.js and browsers.

@HarshaNalluru HarshaNalluru Nov 1, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog

@ljian3377 ljian3377 Nov 2, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

- `BlockBlobClient.uploadFile()`
- `BlockBlobClient.uploadStream()`
- `BlobClient.downloadToBuffer()`
Expand Down
2 changes: 1 addition & 1 deletion sdk/storage/storage-blob/recordings/node/highlevel/recording_after_all_hook.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion sdk/storage/storage-blob/recordings/node/highlevel/recording_before_all_hook.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading