[Recorder] Fixing the missed await for recorder.stop() in the tests in all the packages 📝#12062
Merged
HarshaNalluru merged 3 commits intoAzure:masterfrom Oct 28, 2020
Merged
Conversation
ghost
added
KeyVault
Storage
HarshaNalluru
requested review from
KarishmaGhiya,
XiaoningLiu,
ellismg,
jiacfan,
ljian3377,
ramya-rao-a,
sophiajt and
vinjiang
as code owners
mge
approved these changes
Oct 26, 2020
mge
left a comment
mge
left a comment
There was a problem hiding this comment.
EventGrid stuff looks good to me. Thanks for going ahead and cleaning this up!
ellismg
approved these changes
Oct 26, 2020
Member
ellismg
left a comment
ellismg
left a comment
There was a problem hiding this comment.
From the correct account this time :-)
EventGrid stuff looks good to me. Thanks for going ahead and cleaning this up!
jeremymeng
approved these changes
Oct 27, 2020
Member
jeremymeng
left a comment
jeremymeng
left a comment
There was a problem hiding this comment.
Looks good! Do we want a linter rule for this specific case?
Contributor
Author
Seems like an overkill. Should be good enough to update the docs and existing tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#10013 updated the stop() method that is exported with the recorder to return a promise to make sure certain heavy recordings were recorded properly in the browser, @jeremymeng had updated all the packages to
await recorder.stop().However, some of the tests missed this update. This PR attempts to fix the rest of the tests and any of the
mdfiles that are outdated w.r.t this change.Please make sure the call is awaited from now on. Thanks to @willmtemple for pointing out!