Port from v2.6 | Default Direct TCP Options feature to v4 #7124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
November 8, 2019 16:15
…t from Main.java, and attempted to address a memory leak in the RntbdRequestTimer
…ure-sdk-for-java into feature/cosmos/v4
…n long or int value should specify units
David-Noble-at-work
added
Cosmos
cosmos:v4-item
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
added 2 commits
January 6, 2020 10:17
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
David-Noble-at-work
requested review from
kirankumarkolli,
kushagraThapar and
moderakh
as code owners
moderakh
approved these changes
Jan 7, 2020
Contributor
moderakh
left a comment
moderakh
left a comment
There was a problem hiding this comment.
Already reviewed this on v2. lgtm
Author
|
Failed tests are the result of throttling. Given some on-going production issues this past 24-hours (Reported to me by PM a short while ago) I will squash and merge now and then work with Bhaskar to ensure we've not got a larger issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a straight forward port from v2.6; indirectly from the port to v3. See: