Add support for specifying default Direct TCP options using System properties #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 15, 2019 12:26
…Protocol, -Dazure.cosmos.directModeProtocol (for compatability with v4) and the environment variable DIRECT_MODE_PROTOCOL (which is sometimes convenient in test environments)
…bdTransportClient can now load default direct tcp options
David-Noble-at-work
requested review from
kushagraThapar and
moderakh
as code owners
moderakh
suggested changes
Dec 16, 2019
Contributor
There was a problem hiding this comment.
why do we need to change documentDataFieldSize ReadMyWritesConsistencyTest?
If the intention is to test with different test size and measure the latency, ReadMyWrites or ReadThroughput should be used as a command line tool manually.
The purpose of ReadMyWritesConsistencyTest is not for this. Please use ReadMyWrites as a command line too.
…sistencyTest and fixed a test break.
moderakh
reviewed
Dec 17, 2019
moderakh
reviewed
Dec 17, 2019
...main/java/com/microsoft/azure/cosmosdb/internal/directconnectivity/RntbdTransportClient.java
Show resolved
Hide resolved
…cted failures and renamed a mvn version property for clarity.
moderakh
suggested changes
Dec 17, 2019
...main/java/com/microsoft/azure/cosmosdb/internal/directconnectivity/RntbdTransportClient.java
Outdated
Show resolved
Hide resolved
...main/java/com/microsoft/azure/cosmosdb/internal/directconnectivity/RntbdTransportClient.java
Outdated
Show resolved
Hide resolved
...main/java/com/microsoft/azure/cosmosdb/internal/directconnectivity/RntbdTransportClient.java
Outdated
Show resolved
Hide resolved
moderakh
approved these changes
Dec 17, 2019
Contributor
moderakh
left a comment
moderakh
left a comment
There was a problem hiding this comment.
I added a few more minor comments on the last iterations. Please take a look at the last comments. Other than that lgtm. Signing off.
added 4 commits
December 16, 2019 20:59
…r use by RntbdRequestTimer and renamed long times with unit suffix (e.g., InNanos for nanosecond values and InMillis for millisecond values)
This was referenced Jan 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #298. Also:
-Dcosmos.directModeProtocolthe current mechanism
-Dazure.cosmos.directModeProtoclfor consistency with v4 and azure sdk guidelines
DIRECT_MODE_PROTOCOLenvironment variablefor consistency with other settings that we vary in CI test runs.