Porting reactor netty changes, NPE and minor fixes from v3 to v4 #5989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used Reactor-Core and Reactor-Netty latest release. New TCP Configurations with idle connection timeout, connect timeout, connection keep alive, etc. Used Reactor-Netty's response APIs to convert Flux / Mono to Flux / Mono
Member
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Port of: Azure#5804
Member
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kushagraThapar
approved these changes
Oct 22, 2019
Member
kushagraThapar
left a comment
kushagraThapar
left a comment
There was a problem hiding this comment.
Thank you for porting these two changes.
I have added two comments, please make sure to change them the max_connection_pool_size everywhere to 1000. I missed that change in my reactor netty PR so had to do it later, but we can fix it here :)
sdk/cosmos/azure-cosmos/src/main/java/com/azure/data/cosmos/internal/Configs.java
Outdated
Show resolved
Hide resolved
...smos/azure-cosmos-benchmark/src/main/java/com/azure/data/cosmos/benchmark/Configuration.java
Outdated
Show resolved
Hide resolved
mbhaskar
changed the title
Member
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported reactor netty and NPE fixes from V3
Reactor netty port
ported from: #5185
NPE port:
ported from: #5804
Merge issues and unused imports:
ported from: #5862