Reactor-Netty HttpClient changes #5185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kushagraThapar
requested review from
christopheranderson and
moderakh
as code owners
kushagraThapar
changed the title
moderakh
reviewed
Sep 4, 2019
...soft-azure-cosmos-benchmark/src/main/java/com/azure/data/cosmos/benchmark/Configuration.java
Show resolved
Hide resolved
moderakh
reviewed
Sep 4, 2019
sdk/cosmos/microsoft-azure-cosmos/src/main/java/com/azure/data/cosmos/ConnectionPolicy.java
Outdated
Show resolved
Hide resolved
...oft-azure-cosmos/src/main/java/com/azure/data/cosmos/internal/http/BufferedHttpResponse.java
Outdated
Show resolved
Hide resolved
...s/microsoft-azure-cosmos/src/main/java/com/azure/data/cosmos/internal/http/HttpResponse.java
Outdated
Show resolved
Hide resolved
...mos/microsoft-azure-cosmos/src/main/java/com/azure/data/cosmos/internal/http/HttpClient.java
Outdated
Show resolved
Hide resolved
...mos/microsoft-azure-cosmos/src/main/java/com/azure/data/cosmos/internal/http/HttpClient.java
Outdated
Show resolved
Hide resolved
...mos/microsoft-azure-cosmos/src/main/java/com/azure/data/cosmos/internal/http/HttpClient.java
Outdated
Show resolved
Hide resolved
...osoft-azure-cosmos/src/main/java/com/azure/data/cosmos/internal/http/ReactorNettyClient.java
Outdated
Show resolved
Hide resolved
1. Reverted the RC1 back to M3 version. 2. Added constants for literal values in Configs.java 3. Removed inputStream implementation from HttpResponse.java as its not required
kushagraThapar
changed the title
Member
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…r exception cause
Member
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
openapi-bot-ppe bot
pushed a commit
to test-repo-billy/azure-sdk-for-java
that referenced
this pull request
Oct 21, 2019
* Reactor Netty Milestone release changes * Updated Milestone version to RC version * Code review comments: 1. Reverted the RC1 back to M3 version. 2. Added constants for literal values in Configs.java 3. Removed inputStream implementation from HttpResponse.java as its not required * Setting default connections to 1000, and fixed Exception handling by unwrapping exception * Unwrapping exception * Fixed validate failure by unwrapping exception * Fixed multi-master conflict resolution test * Unwrapping exceptions wherever possible to make sure we check on inner exception cause * Fixed compilation errors * Fixed doOnError in Store Client and Consistency Writer to handle unwrapped exceptions * Handling empty response from backend * Updating number of documents and collection throughput size * Updated Feed Response Validator for query metrics * Fixed query documents with aggregate test * Updated retrieved documents count * Updated getLogicalPlanBuildTime for query metrics validation * Unused imports
openapi-bot-ppe bot
pushed a commit
to test-repo-billy/azure-sdk-for-java
that referenced
this pull request
Oct 21, 2019
* Reactor Netty Milestone release changes * Updated Milestone version to RC version * Code review comments: 1. Reverted the RC1 back to M3 version. 2. Added constants for literal values in Configs.java 3. Removed inputStream implementation from HttpResponse.java as its not required * Setting default connections to 1000, and fixed Exception handling by unwrapping exception * Unwrapping exception * Fixed validate failure by unwrapping exception * Fixed multi-master conflict resolution test * Unwrapping exceptions wherever possible to make sure we check on inner exception cause * Fixed compilation errors * Fixed doOnError in Store Client and Consistency Writer to handle unwrapped exceptions * Handling empty response from backend * Updating number of documents and collection throughput size * Updated Feed Response Validator for query metrics * Fixed query documents with aggregate test * Updated retrieved documents count * Updated getLogicalPlanBuildTime for query metrics validation * Unused imports
openapi-bot-ppe bot
pushed a commit
to test-repo-billy/azure-sdk-for-java
that referenced
this pull request
Oct 21, 2019
* Reactor Netty Milestone release changes * Updated Milestone version to RC version * Code review comments: 1. Reverted the RC1 back to M3 version. 2. Added constants for literal values in Configs.java 3. Removed inputStream implementation from HttpResponse.java as its not required * Setting default connections to 1000, and fixed Exception handling by unwrapping exception * Unwrapping exception * Fixed validate failure by unwrapping exception * Fixed multi-master conflict resolution test * Unwrapping exceptions wherever possible to make sure we check on inner exception cause * Fixed compilation errors * Fixed doOnError in Store Client and Consistency Writer to handle unwrapped exceptions * Handling empty response from backend * Updating number of documents and collection throughput size * Updated Feed Response Validator for query metrics * Fixed query documents with aggregate test * Updated retrieved documents count * Updated getLogicalPlanBuildTime for query metrics validation * Unused imports
openapi-bot-ppe bot
pushed a commit
to test-repo-billy/azure-sdk-for-java
that referenced
this pull request
Oct 21, 2019
* Reactor Netty Milestone release changes * Updated Milestone version to RC version * Code review comments: 1. Reverted the RC1 back to M3 version. 2. Added constants for literal values in Configs.java 3. Removed inputStream implementation from HttpResponse.java as its not required * Setting default connections to 1000, and fixed Exception handling by unwrapping exception * Unwrapping exception * Fixed validate failure by unwrapping exception * Fixed multi-master conflict resolution test * Unwrapping exceptions wherever possible to make sure we check on inner exception cause * Fixed compilation errors * Fixed doOnError in Store Client and Consistency Writer to handle unwrapped exceptions * Handling empty response from backend * Updating number of documents and collection throughput size * Updated Feed Response Validator for query metrics * Fixed query documents with aggregate test * Updated retrieved documents count * Updated getLogicalPlanBuildTime for query metrics validation * Unused imports
openapi-bot-ppe bot
pushed a commit
to test-repo-billy/azure-sdk-for-java
that referenced
this pull request
Oct 21, 2019
* Reactor Netty Milestone release changes * Updated Milestone version to RC version * Code review comments: 1. Reverted the RC1 back to M3 version. 2. Added constants for literal values in Configs.java 3. Removed inputStream implementation from HttpResponse.java as its not required * Setting default connections to 1000, and fixed Exception handling by unwrapping exception * Unwrapping exception * Fixed validate failure by unwrapping exception * Fixed multi-master conflict resolution test * Unwrapping exceptions wherever possible to make sure we check on inner exception cause * Fixed compilation errors * Fixed doOnError in Store Client and Consistency Writer to handle unwrapped exceptions * Handling empty response from backend * Updating number of documents and collection throughput size * Updated Feed Response Validator for query metrics * Fixed query documents with aggregate test * Updated retrieved documents count * Updated getLogicalPlanBuildTime for query metrics validation * Unused imports
openapi-bot-ppe bot
pushed a commit
to test-repo-billy/azure-sdk-for-java
that referenced
this pull request
Oct 22, 2019
* Reactor Netty Milestone release changes * Updated Milestone version to RC version * Code review comments: 1. Reverted the RC1 back to M3 version. 2. Added constants for literal values in Configs.java 3. Removed inputStream implementation from HttpResponse.java as its not required * Setting default connections to 1000, and fixed Exception handling by unwrapping exception * Unwrapping exception * Fixed validate failure by unwrapping exception * Fixed multi-master conflict resolution test * Unwrapping exceptions wherever possible to make sure we check on inner exception cause * Fixed compilation errors * Fixed doOnError in Store Client and Consistency Writer to handle unwrapped exceptions * Handling empty response from backend * Updating number of documents and collection throughput size * Updated Feed Response Validator for query metrics * Fixed query documents with aggregate test * Updated retrieved documents count * Updated getLogicalPlanBuildTime for query metrics validation * Unused imports
openapi-bot-ppe bot
pushed a commit
to test-repo-billy/azure-sdk-for-java
that referenced
this pull request
Oct 22, 2019
* Reactor Netty Milestone release changes * Updated Milestone version to RC version * Code review comments: 1. Reverted the RC1 back to M3 version. 2. Added constants for literal values in Configs.java 3. Removed inputStream implementation from HttpResponse.java as its not required * Setting default connections to 1000, and fixed Exception handling by unwrapping exception * Unwrapping exception * Fixed validate failure by unwrapping exception * Fixed multi-master conflict resolution test * Unwrapping exceptions wherever possible to make sure we check on inner exception cause * Fixed compilation errors * Fixed doOnError in Store Client and Consistency Writer to handle unwrapped exceptions * Handling empty response from backend * Updating number of documents and collection throughput size * Updated Feed Response Validator for query metrics * Fixed query documents with aggregate test * Updated retrieved documents count * Updated getLogicalPlanBuildTime for query metrics validation * Unused imports
openapi-bot-ppe bot
pushed a commit
to test-repo-billy/azure-sdk-for-java
that referenced
this pull request
Oct 22, 2019
* Reactor Netty Milestone release changes * Updated Milestone version to RC version * Code review comments: 1. Reverted the RC1 back to M3 version. 2. Added constants for literal values in Configs.java 3. Removed inputStream implementation from HttpResponse.java as its not required * Setting default connections to 1000, and fixed Exception handling by unwrapping exception * Unwrapping exception * Fixed validate failure by unwrapping exception * Fixed multi-master conflict resolution test * Unwrapping exceptions wherever possible to make sure we check on inner exception cause * Fixed compilation errors * Fixed doOnError in Store Client and Consistency Writer to handle unwrapped exceptions * Handling empty response from backend * Updating number of documents and collection throughput size * Updated Feed Response Validator for query metrics * Fixed query documents with aggregate test * Updated retrieved documents count * Updated getLogicalPlanBuildTime for query metrics validation * Unused imports
openapi-bot-ppe bot
pushed a commit
to test-repo-billy/azure-sdk-for-java
that referenced
this pull request
Oct 22, 2019
* Reactor Netty Milestone release changes * Updated Milestone version to RC version * Code review comments: 1. Reverted the RC1 back to M3 version. 2. Added constants for literal values in Configs.java 3. Removed inputStream implementation from HttpResponse.java as its not required * Setting default connections to 1000, and fixed Exception handling by unwrapping exception * Unwrapping exception * Fixed validate failure by unwrapping exception * Fixed multi-master conflict resolution test * Unwrapping exceptions wherever possible to make sure we check on inner exception cause * Fixed compilation errors * Fixed doOnError in Store Client and Consistency Writer to handle unwrapped exceptions * Handling empty response from backend * Updating number of documents and collection throughput size * Updated Feed Response Validator for query metrics * Fixed query documents with aggregate test * Updated retrieved documents count * Updated getLogicalPlanBuildTime for query metrics validation * Unused imports
openapi-bot-ppe bot
pushed a commit
to test-repo-billy/azure-sdk-for-java
that referenced
this pull request
Oct 22, 2019
* Reactor Netty Milestone release changes * Updated Milestone version to RC version * Code review comments: 1. Reverted the RC1 back to M3 version. 2. Added constants for literal values in Configs.java 3. Removed inputStream implementation from HttpResponse.java as its not required * Setting default connections to 1000, and fixed Exception handling by unwrapping exception * Unwrapping exception * Fixed validate failure by unwrapping exception * Fixed multi-master conflict resolution test * Unwrapping exceptions wherever possible to make sure we check on inner exception cause * Fixed compilation errors * Fixed doOnError in Store Client and Consistency Writer to handle unwrapped exceptions * Handling empty response from backend * Updating number of documents and collection throughput size * Updated Feed Response Validator for query metrics * Fixed query documents with aggregate test * Updated retrieved documents count * Updated getLogicalPlanBuildTime for query metrics validation * Unused imports
openapi-bot-ppe bot
pushed a commit
to test-repo-billy/azure-sdk-for-java
that referenced
this pull request
Oct 25, 2019
* Reactor Netty Milestone release changes * Updated Milestone version to RC version * Code review comments: 1. Reverted the RC1 back to M3 version. 2. Added constants for literal values in Configs.java 3. Removed inputStream implementation from HttpResponse.java as its not required * Setting default connections to 1000, and fixed Exception handling by unwrapping exception * Unwrapping exception * Fixed validate failure by unwrapping exception * Fixed multi-master conflict resolution test * Unwrapping exceptions wherever possible to make sure we check on inner exception cause * Fixed compilation errors * Fixed doOnError in Store Client and Consistency Writer to handle unwrapped exceptions * Handling empty response from backend * Updating number of documents and collection throughput size * Updated Feed Response Validator for query metrics * Fixed query documents with aggregate test * Updated retrieved documents count * Updated getLogicalPlanBuildTime for query metrics validation * Unused imports
openapi-bot-ppe bot
pushed a commit
to test-repo-billy/azure-sdk-for-java
that referenced
this pull request
Oct 25, 2019
* Reactor Netty Milestone release changes * Updated Milestone version to RC version * Code review comments: 1. Reverted the RC1 back to M3 version. 2. Added constants for literal values in Configs.java 3. Removed inputStream implementation from HttpResponse.java as its not required * Setting default connections to 1000, and fixed Exception handling by unwrapping exception * Unwrapping exception * Fixed validate failure by unwrapping exception * Fixed multi-master conflict resolution test * Unwrapping exceptions wherever possible to make sure we check on inner exception cause * Fixed compilation errors * Fixed doOnError in Store Client and Consistency Writer to handle unwrapped exceptions * Handling empty response from backend * Updating number of documents and collection throughput size * Updated Feed Response Validator for query metrics * Fixed query documents with aggregate test * Updated retrieved documents count * Updated getLogicalPlanBuildTime for query metrics validation * Unused imports
openapi-bot-ppe bot
pushed a commit
to test-repo-billy/azure-sdk-for-java
that referenced
this pull request
Oct 25, 2019
* Reactor Netty Milestone release changes * Updated Milestone version to RC version * Code review comments: 1. Reverted the RC1 back to M3 version. 2. Added constants for literal values in Configs.java 3. Removed inputStream implementation from HttpResponse.java as its not required * Setting default connections to 1000, and fixed Exception handling by unwrapping exception * Unwrapping exception * Fixed validate failure by unwrapping exception * Fixed multi-master conflict resolution test * Unwrapping exceptions wherever possible to make sure we check on inner exception cause * Fixed compilation errors * Fixed doOnError in Store Client and Consistency Writer to handle unwrapped exceptions * Handling empty response from backend * Updating number of documents and collection throughput size * Updated Feed Response Validator for query metrics * Fixed query documents with aggregate test * Updated retrieved documents count * Updated getLogicalPlanBuildTime for query metrics validation * Unused imports
openapi-bot-ppe bot
pushed a commit
to test-repo-billy/azure-sdk-for-java
that referenced
this pull request
Oct 25, 2019
* Reactor Netty Milestone release changes * Updated Milestone version to RC version * Code review comments: 1. Reverted the RC1 back to M3 version. 2. Added constants for literal values in Configs.java 3. Removed inputStream implementation from HttpResponse.java as its not required * Setting default connections to 1000, and fixed Exception handling by unwrapping exception * Unwrapping exception * Fixed validate failure by unwrapping exception * Fixed multi-master conflict resolution test * Unwrapping exceptions wherever possible to make sure we check on inner exception cause * Fixed compilation errors * Fixed doOnError in Store Client and Consistency Writer to handle unwrapped exceptions * Handling empty response from backend * Updating number of documents and collection throughput size * Updated Feed Response Validator for query metrics * Fixed query documents with aggregate test * Updated retrieved documents count * Updated getLogicalPlanBuildTime for query metrics validation * Unused imports
openapi-bot-ppe bot
pushed a commit
to test-repo-billy/azure-sdk-for-java
that referenced
this pull request
Oct 25, 2019
* Reactor Netty Milestone release changes * Updated Milestone version to RC version * Code review comments: 1. Reverted the RC1 back to M3 version. 2. Added constants for literal values in Configs.java 3. Removed inputStream implementation from HttpResponse.java as its not required * Setting default connections to 1000, and fixed Exception handling by unwrapping exception * Unwrapping exception * Fixed validate failure by unwrapping exception * Fixed multi-master conflict resolution test * Unwrapping exceptions wherever possible to make sure we check on inner exception cause * Fixed compilation errors * Fixed doOnError in Store Client and Consistency Writer to handle unwrapped exceptions * Handling empty response from backend * Updating number of documents and collection throughput size * Updated Feed Response Validator for query metrics * Fixed query documents with aggregate test * Updated retrieved documents count * Updated getLogicalPlanBuildTime for query metrics validation * Unused imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: