Skip to content

[AutoPR azure-resourcemanager-resources-deploymentstacks]-generated-from-SDK Generation - Java-5803514#47817

Merged
weidongxu-microsoft merged 10 commits intoAzure:mainfrom
azure-sdk:sdkauto/azure-resourcemanager-resources-deploymentstacks-5803514
Feb 11, 2026
Merged

[AutoPR azure-resourcemanager-resources-deploymentstacks]-generated-from-SDK Generation - Java-5803514#47817
weidongxu-microsoft merged 10 commits intoAzure:mainfrom
azure-sdk:sdkauto/azure-resourcemanager-resources-deploymentstacks-5803514

Conversation

@azure-sdk
Copy link
Collaborator

@azure-sdk azure-sdk commented Jan 27, 2026

Configurations: 'specification/resources/resource-manager/Microsoft.Resources/deploymentStacks/tspconfig.yaml', API Version: 2025-07-01, SDK Release Type: stable, and CommitSHA: '652ad4cb131256f10a90ea2df207b38cf35d6671' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5803514 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=0a321955-acfb-f011-8406-000d3a3ac981 Submitted by: kylealbert@microsoft.com

Release Plan Details

…esources/deploymentStacks/tspconfig.yaml', API Version: 2025-07-01, SDK Release Type: stable, and CommitSHA: '652ad4cb131256f10a90ea2df207b38cf35d6671' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5803514 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label Jan 27, 2026
@kalbert312 kalbert312 marked this pull request as ready for review January 27, 2026 20:18
Copilot AI review requested due to automatic review settings January 27, 2026 20:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This is an automated SDK generation PR that updates the Azure Deployment Stacks resource manager library from AutoRest to TypeSpec code generation, introducing API version 2025-07-01. The PR represents a stable release (1.1.0) of the deployment stacks library with significant API enhancements.

Changes:

  • Migration from AutoRest to TypeSpec code generator with updated attribution comments throughout
  • Introduction of new WhatIf API operations for previewing deployment stack changes across subscription, resource group, and management group scopes
  • Addition of deployment extension support with configuration models
  • API breaking changes including removal of UnmanageAction* enum types replaced by unified DeploymentStacksDeleteDetachEnum

Reviewed changes

Copilot reviewed 97 out of 157 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
sdk/resources/azure-resourcemanager-resources/README.md Updates version reference to 2.54.0-beta.1
sdk/resources/azure-resourcemanager-resources/CHANGELOG.md Critical Issue: Incorrectly changes version to 1.1.0 (wrong library)
sdk/resources/azure-resourcemanager-resources-deploymentstacks/tsp-location.yaml Adds TypeSpec location configuration
sdk/resources/azure-resourcemanager-resources-deploymentstacks/src/test/** Adds comprehensive test coverage for new models and APIs
sdk/resources/azure-resourcemanager-resources-deploymentstacks/src/samples/** Adds usage samples for new WhatIf APIs
sdk/resources/azure-resourcemanager-resources-deploymentstacks/src/main/** Migrates to TypeSpec-generated code with new WhatIf and extension models
sdk/resources/azure-resourcemanager-resources-deploymentstacks/pom.xml Updates to version 1.1.0 and TypeSpec attribution
eng/versioning/version_client.txt Updates version tracking for deployment stacks library

@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2026

API Change Check

APIView identified API level changes in this PR and created the following API reviews

com.azure.resourcemanager:azure-resourcemanager-resources-deploymentstacks

@weidongxu-microsoft
Copy link
Member

weidongxu-microsoft commented Jan 28, 2026

Hi @kalbert312 ,

I saw a break from your migration.

Before, in Swagger, there is 3 different enum (UnmanageActionResourceMode, UnmanageActionResourceGroupMode, UnmanageActionManagementGroupMode) for 3 parameters on DeploymentStacks_DeleteAtResourceGroup
https://github.com/Azure/azure-rest-api-specs/blob/2e5d83cb6120f521e833f7dfc56f6397592581dd/specification/resources/resource-manager/Microsoft.Resources/deploymentStacks/stable/2024-03-01/deploymentStacks.json#L1598-L1645

Now in TypeSpec, you only have 1 single DeploymentStacksDeleteDetachEnum for all 3 parameters.

This would be a break that likely cannot be mitigated by SDK. Are you sure this is correct?

PS: the naming DeploymentStacksDeleteDetachEnum is not great...

azure-sdk and others added 2 commits January 28, 2026 07:06
@kalbert312
Copy link
Member

Hi @kalbert312 ,

I saw a break from your migration.

Before, in Swagger, there is 3 different enum (UnmanageActionResourceMode, UnmanageActionResourceGroupMode, UnmanageActionManagementGroupMode) for 3 parameters on DeploymentStacks_DeleteAtResourceGroup https://github.com/Azure/azure-rest-api-specs/blob/2e5d83cb6120f521e833f7dfc56f6397592581dd/specification/resources/resource-manager/Microsoft.Resources/deploymentStacks/stable/2024-03-01/deploymentStacks.json#L1598-L1645

Now in TypeSpec, you only have 1 single DeploymentStacksDeleteDetachEnum for all 3 parameters.

This would be a break that likely cannot be mitigated by SDK. Are you sure this is correct?

PS: the naming DeploymentStacksDeleteDetachEnum is not great...

I guess we can revert this to avoid customer confusion. The justification was that this is a single enum on the backend (which is named "CleanupActionType" which is a better name, I agree the name is bad). The justification for keeping them as separate types is if one of them diverged and accepted a different action type, this would be more easily scoped by the SDK.

@kalbert312
Copy link
Member

Hi @kalbert312 ,
I saw a break from your migration.
Before, in Swagger, there is 3 different enum (UnmanageActionResourceMode, UnmanageActionResourceGroupMode, UnmanageActionManagementGroupMode) for 3 parameters on DeploymentStacks_DeleteAtResourceGroup https://github.com/Azure/azure-rest-api-specs/blob/2e5d83cb6120f521e833f7dfc56f6397592581dd/specification/resources/resource-manager/Microsoft.Resources/deploymentStacks/stable/2024-03-01/deploymentStacks.json#L1598-L1645
Now in TypeSpec, you only have 1 single DeploymentStacksDeleteDetachEnum for all 3 parameters.
This would be a break that likely cannot be mitigated by SDK. Are you sure this is correct?
PS: the naming DeploymentStacksDeleteDetachEnum is not great...

I guess we can revert this to avoid customer confusion. The justification was that this is a single enum on the backend (which is named "CleanupActionType" which is a better name, I agree the name is bad). The justification for keeping them as separate types is if one of them diverged and accepted a different action type, this would be more easily scoped by the SDK.

PR: Azure/azure-rest-api-specs#39987

@weidongxu-microsoft
Copy link
Member

PR: Azure/azure-rest-api-specs#39987

Thanks. I've approved it. Also asked dev from other languages to comment (especially if any of them do not want this fix).

@weidongxu-microsoft
Copy link
Member

.NET also doing a PR on specs repo Azure/azure-rest-api-specs#40198

@weidongxu-microsoft
Copy link
Member

@kalbert312

PR ready. We need approval from service to merge.

@kalbert312
Copy link
Member

@weidongxu-microsoft I want to confirm this includes the latest changes merged to rest api specs? We had to do some additional updates for .NET.

@weidongxu-microsoft
Copy link
Member

.NET also doing a PR on specs repo Azure/azure-rest-api-specs#40198

@kalbert312

We've re-generated Java, after this .NET PR merged.

Do we have anything more?

@kalbert312
Copy link
Member

.NET also doing a PR on specs repo Azure/azure-rest-api-specs#40198

@kalbert312

We've re-generated Java, after this .NET PR merged.

Do we have anything more?

No

@kalbert312
Copy link
Member

@Azure/azure-java-sdk @ArthurMa1978 @haolingdong-msft @XiaofeiCao looking for approval.

@weidongxu-microsoft weidongxu-microsoft merged commit d25a0a1 into Azure:main Feb 11, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management-plane library.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants