[ARM] Deployment Stacks Typespec Fixes.

[kalbert312]

Contains feedback fixes from initial SDK code gen attempt. #39954

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

• New resource provider.
• New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
• Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
• Update existing version to fix OpenAPI spec quality issues in S360.
• Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
• Other, please clarify:
  • Fixes from review of SDK generated code.

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

• I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
• I have reviewed following Resource Provider guidelines, including
  ARM resource provider contract and
  REST guidelines (estimated time: 4 hours).
  I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
• A release plan has been created. If not, please create one as it will help guide you through the REST API and SDK creation process.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

• First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
• If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
• To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
• For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
  and https://aka.ms/ci-fix.
• For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
• If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
  This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
• If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.
• For guidance on SDK breaking change review, refer to https://aka.ms/ci-fix.

[github-actions]

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Comment generated by summarize-checks workflow run.

[github-actions]

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language	API Review for Package
TypeSpec	Microsoft.Resources.DeploymentStacks
Go	sdk/resourcemanager/resources/armdeploymentstacks
JavaScript	@azure/arm-resourcesdeploymentstacks
Swagger	Microsoft.Authorization-deploymentStacks
Python	azure-mgmt-resource-deploymentstacks
Java	com.azure.resourcemanager:azure-resourcemanager-resources-deploymentstacks

[msyyc]

Looks good to python

[kazrael2119]

need revert DeploymentStacksDeleteDetachEnum changes for JS

as this will introduce breaking changes for JS sdk.
breaking:

[weidongxu-microsoft]

need revert DeploymentStacksDeleteDetachEnum changes for JS as this will introduce breaking changes for JS sdk. breaking:

@kazrael2119

OK, so JS has released the lib using DeploymentStacksDeleteDetachEnum, while other libs are in previous UnmanageActionResourceMode etc.

We probably can do a clientName+alternativeType to make it backward-compatible with DeploymentStacksDeleteDetachEnum. Can you have Mary or Qiaoqiao confirm this is what JS want to do?
(the client and client method part in JS apiview changes too much, that I cannot see whether there is change on client method level)

[kazrael2119]

need revert DeploymentStacksDeleteDetachEnum changes for JS as this will introduce breaking changes for JS sdk. breaking:

@kazrael2119

OK, so JS has released the lib using DeploymentStacksDeleteDetachEnum, while other libs are in previous UnmanageActionResourceMode etc.

We probably can do a clientName+alternativeType to make it backward-compatible with DeploymentStacksDeleteDetachEnum. Can you have Mary or Qiaoqiao confirm this is what JS want to do? (the client and client method part in JS apiview changes too much, that I cannot see whether there is change on client method level)

confirmed with @qiaozha , JS will take this break.

[weidongxu-microsoft]

@kazrael2119 Do you mean JS can use UnmanageActionResourceMode, correct?

@kalbert312
If so, we've had all SDK OKed on this change.

.NET seems haven't released the DeploymentStacks in any GA version, so they would be fine. (I notified Wei Hu too)

[kalbert312]

Changeset was already merged.