Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
89496d3
Porting over changes from private repo
jpalvarezl Dec 2, 2025
eca457f
formatting
jpalvarezl Dec 2, 2025
954ba7d
Update sdk/ai/azure-ai-agents/src/main/java/com/azure/ai/agents/imple…
jpalvarezl Dec 3, 2025
4df3dba
Update sdk/ai/azure-ai-agents/src/main/java/com/azure/ai/agents/imple…
jpalvarezl Dec 3, 2025
385e9b5
Formatting mismatch
jpalvarezl Dec 3, 2025
0957fd2
Add async and error propagation test coverage for PolicyDecoratingHtt…
Copilot Dec 3, 2025
d113cc2
Add error handling tests for HttpClientHelper (#47428)
Copilot Dec 3, 2025
224e3fb
Merged and improved assertions
jpalvarezl Dec 3, 2025
672a6df
More PR feedback
jpalvarezl Dec 3, 2025
d4505e6
More PR feedback
jpalvarezl Dec 3, 2025
bf085da
More PR feedback
jpalvarezl Dec 3, 2025
226c2c0
lazy mapping of types for the AzureHttpResponseAdapter
jpalvarezl Dec 4, 2025
7c95643
Simplified mapping
jpalvarezl Dec 4, 2025
867d0d6
Always using default httpPipeline
jpalvarezl Dec 5, 2025
6bf38b7
Using bare minimum code
jpalvarezl Dec 5, 2025
7c1b414
WIP: removing redundant code. Using default httpPipeline
jpalvarezl Dec 5, 2025
96153b7
fix async tests
srnagar Dec 9, 2025
a4e5c29
Code style checks
jpalvarezl Dec 10, 2025
8e760a9
Added recording for async test
jpalvarezl Dec 10, 2025
94b0797
Merge branch 'main' into feature/stainless_httpclient_instrumentation
jpalvarezl Dec 11, 2025
b4bbdd3
Enabled sync tests and update assets
jpalvarezl Dec 11, 2025
b9a37e8
Updated test suite and restored value for context config
jpalvarezl Dec 11, 2025
ce40dab
Using latest version of azure-core-test
jpalvarezl Dec 11, 2025
a53bbd1
Forwarding request timeout and adding more custom machters for tests
jpalvarezl Dec 11, 2025
d9293fa
reassign addData result
jpalvarezl Dec 11, 2025
27aa57f
WIP: timeout tests
jpalvarezl Dec 11, 2025
edcf29d
Timeout tests are run only in Live test mode
jpalvarezl Dec 11, 2025
28d3d6e
Test asset update
jpalvarezl Dec 11, 2025
275e2e9
Exceptions are allowed to propagate upwards
jpalvarezl Dec 11, 2025
8c77862
Error mapping in place
jpalvarezl Dec 11, 2025
2fcfb4d
reformat
jpalvarezl Dec 11, 2025
f4206bb
Format
jpalvarezl Dec 11, 2025
67c9970
Fixed timeout tests
jpalvarezl Dec 11, 2025
38694bb
PR feedback 1st round
jpalvarezl Dec 12, 2025
6967620
PR feedback round 2: pom updates
jpalvarezl Dec 12, 2025
41ca65d
dependency tag fixed and disabled test
jpalvarezl Dec 12, 2025
f0fc0ed
Disabled flacky timeout tests
jpalvarezl Dec 12, 2025
ad2d539
Disabled one more test
jpalvarezl Dec 12, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@

import com.azure.ai.agents.implementation.AgentsClientImpl;
import com.azure.ai.agents.implementation.TokenUtils;
import com.azure.ai.agents.implementation.http.HttpClientHelper;
import com.azure.ai.agents.implementation.http.PolicyDecoratingHttpClient;
import com.azure.core.annotation.Generated;
import com.azure.core.annotation.ServiceClientBuilder;
import com.azure.core.client.traits.ConfigurationTrait;
Expand Down Expand Up @@ -43,6 +45,7 @@
import com.openai.credential.BearerTokenCredential;
import java.time.Duration;
import java.util.ArrayList;
import java.util.Collections;
import java.util.List;
import java.util.Map;
import java.util.Objects;
Expand Down Expand Up @@ -328,7 +331,12 @@ private HttpPipeline createHttpPipeline() {
* @return an instance of ConversationsAsyncClient.
*/
public ConversationsAsyncClient buildConversationsAsyncClient() {
return new ConversationsAsyncClient(getOpenAIAsyncClientBuilder().build());
HttpClient decoratedHttpClient = getOpenAIHttpClient();
return new ConversationsAsyncClient(getOpenAIAsyncClientBuilder().build().withOptions(optionBuilder -> {
if (decoratedHttpClient != null) {
optionBuilder.httpClient(HttpClientHelper.httpClientMapper(decoratedHttpClient));
}
}));
}

/**
Expand All @@ -337,7 +345,12 @@ public ConversationsAsyncClient buildConversationsAsyncClient() {
* @return an instance of ConversationsClient.
*/
public ConversationsClient buildConversationsClient() {
return new ConversationsClient(getOpenAIClientBuilder().build());
HttpClient decoratedHttpClient = getOpenAIHttpClient();
return new ConversationsClient(getOpenAIClientBuilder().build().withOptions(optionBuilder -> {
if (decoratedHttpClient != null) {
optionBuilder.httpClient(HttpClientHelper.httpClientMapper(decoratedHttpClient));
Comment thread
jpalvarezl marked this conversation as resolved.
Outdated
}
}));
}

/**
Expand All @@ -346,8 +359,12 @@ public ConversationsClient buildConversationsClient() {
* @return an instance of ResponsesClient
*/
public ResponsesClient buildResponsesClient() {
OpenAIOkHttpClient.Builder builder = getOpenAIClientBuilder();
return new ResponsesClient(builder.build());
HttpClient decoratedHttpClient = getOpenAIHttpClient();
return new ResponsesClient(getOpenAIClientBuilder().build().withOptions(optionBuilder -> {
if (decoratedHttpClient != null) {
optionBuilder.httpClient(HttpClientHelper.httpClientMapper(decoratedHttpClient));
}
}));
}

/**
Expand All @@ -356,7 +373,12 @@ public ResponsesClient buildResponsesClient() {
* @return an instance of ResponsesAsyncClient
*/
public ResponsesAsyncClient buildResponsesAsyncClient() {
return new ResponsesAsyncClient(getOpenAIAsyncClientBuilder().build());
HttpClient decoratedHttpClient = getOpenAIHttpClient();
return new ResponsesAsyncClient(getOpenAIAsyncClientBuilder().build().withOptions(optionBuilder -> {
if (decoratedHttpClient != null) {
optionBuilder.httpClient(HttpClientHelper.httpClientMapper(decoratedHttpClient));
}
}));
}

private OpenAIOkHttpClient.Builder getOpenAIClientBuilder() {
Expand Down Expand Up @@ -396,6 +418,36 @@ private String getUserAgent() {
return UserAgentUtil.toUserAgentString(applicationId, sdkName, sdkVersion, configuration);
}

private HttpClient getOpenAIHttpClient() {
if (this.httpClient == null) {
return null;
}
List<HttpPipelinePolicy> orderedPolicies = getOrderedCustomPolicies();
Comment thread
jpalvarezl marked this conversation as resolved.
Outdated
if (orderedPolicies.isEmpty()) {
Comment thread
jpalvarezl marked this conversation as resolved.
Outdated
return this.httpClient;
}
Comment thread
jpalvarezl marked this conversation as resolved.
Outdated
return new PolicyDecoratingHttpClient(this.httpClient, orderedPolicies);
}

private List<HttpPipelinePolicy> getOrderedCustomPolicies() {
if (this.pipelinePolicies.isEmpty()) {
return Collections.emptyList();
}
List<HttpPipelinePolicy> orderedPolicies = new ArrayList<>();
this.pipelinePolicies.stream()
.filter(policy -> pipelinePosition(policy) == HttpPipelinePosition.PER_CALL)
.forEach(orderedPolicies::add);
this.pipelinePolicies.stream()
.filter(policy -> pipelinePosition(policy) == HttpPipelinePosition.PER_RETRY)
.forEach(orderedPolicies::add);
return orderedPolicies;
Comment thread
jpalvarezl marked this conversation as resolved.
Outdated
}

private static HttpPipelinePosition pipelinePosition(HttpPipelinePolicy policy) {
HttpPipelinePosition position = policy.getPipelinePosition();
return position == null ? HttpPipelinePosition.PER_RETRY : position;
}

private static final ClientLogger LOGGER = new ClientLogger(AgentsClientBuilder.class);

/**
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License.

package com.azure.ai.agents.implementation.http;

import com.azure.core.http.HttpHeader;
import com.azure.core.http.HttpHeaders;
import com.azure.core.util.logging.ClientLogger;
import com.openai.core.http.Headers;
import com.openai.core.http.HttpResponse;

import java.io.IOException;
import java.io.InputStream;
import java.io.UncheckedIOException;

/**
* Adapter that exposes an Azure {@link com.azure.core.http.HttpResponse} as an OpenAI {@link HttpResponse}. This keeps
* the translation logic encapsulated so response handling elsewhere can remain framework agnostic.
*/
final class AzureHttpResponseAdapter implements HttpResponse {

private static final ClientLogger LOGGER = new ClientLogger(AzureHttpResponseAdapter.class);

private final com.azure.core.http.HttpResponse azureResponse;
private final Headers headers;
private final InputStream bodyStream;

/**
* Creates a new adapter instance for the provided Azure response.
*
* @param azureResponse Response returned by the Azure pipeline.
*/
AzureHttpResponseAdapter(com.azure.core.http.HttpResponse azureResponse) {
this.azureResponse = azureResponse;
this.headers = toOpenAiHeaders(azureResponse.getHeaders());
Comment thread
jpalvarezl marked this conversation as resolved.
Outdated
this.bodyStream = azureResponse.getBodyAsBinaryData().toStream();
Comment thread
jpalvarezl marked this conversation as resolved.
Outdated
}

@Override
public int statusCode() {
return azureResponse.getStatusCode();
}

@Override
public Headers headers() {
return headers;
}

@Override
public InputStream body() {
return bodyStream;
}

@Override
public void close() {
try {
bodyStream.close();
} catch (IOException ex) {
throw LOGGER.logExceptionAsWarning(new UncheckedIOException("Failed to close response body stream", ex));
}
}

/**
* Copies headers from the Azure response into the immutable OpenAI {@link Headers} collection.
*/
private static Headers toOpenAiHeaders(HttpHeaders httpHeaders) {
Headers.Builder builder = Headers.builder();
for (HttpHeader header : httpHeaders) {
builder.put(header.getName(), header.getValuesList());
}
return builder.build();
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,191 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License.

package com.azure.ai.agents.implementation.http;

import com.azure.core.http.HttpHeaderName;
import com.azure.core.http.HttpHeaders;
import com.azure.core.util.BinaryData;
import com.azure.core.util.Context;
import com.azure.core.util.CoreUtils;
import com.azure.core.util.logging.ClientLogger;
import com.openai.core.RequestOptions;
import com.openai.core.http.Headers;
import com.openai.core.http.HttpRequest;
import com.openai.core.http.HttpRequestBody;
import com.openai.core.http.HttpResponse;

import java.io.ByteArrayOutputStream;
import java.io.IOException;
import java.io.UncheckedIOException;
import java.util.List;
import java.util.Objects;
import java.util.concurrent.CompletableFuture;

/**
* Utility entry point that adapts an Azure {@link com.azure.core.http.HttpClient} so it can be consumed by
* the OpenAI SDK generated clients. The helper performs request/response translation so that existing Azure
* pipelines, diagnostics, and retry policies can be reused without exposing the Azure HTTP primitives to
* callers that only understand the OpenAI surface area.
*/
public final class HttpClientHelper {

private static final ClientLogger LOGGER = new ClientLogger(HttpClientHelper.class);

private HttpClientHelper() {
}

/**
* Wraps the given Azure {@link com.azure.core.http.HttpClient} with an implementation of the OpenAI
* {@link com.openai.core.http.HttpClient} interface. All requests and responses are converted on the fly.
*
* @param azureHttpClient The Azure HTTP client that should execute requests.
* @return A bridge client that honors the OpenAI interface but delegates execution to the Azure pipeline.
*/
public static com.openai.core.http.HttpClient httpClientMapper(com.azure.core.http.HttpClient azureHttpClient) {
Comment thread
jpalvarezl marked this conversation as resolved.
Outdated
return new HttpClientWrapper(azureHttpClient);
}

private static final class HttpClientWrapper implements com.openai.core.http.HttpClient {

private static final HttpHeaderName CONTENT_TYPE = HttpHeaderName.CONTENT_TYPE;
Comment thread
jpalvarezl marked this conversation as resolved.
Outdated

private final com.azure.core.http.HttpClient azureHttpClient;

private HttpClientWrapper(com.azure.core.http.HttpClient azureHttpClient) {
this.azureHttpClient = Objects.requireNonNull(azureHttpClient, "'azureHttpClient' cannot be null.");
}

@Override
public void close() {
// no-op
}

@Override
public HttpResponse execute(HttpRequest request) {
return execute(request, RequestOptions.none());
}

@Override
public HttpResponse execute(HttpRequest request, RequestOptions requestOptions) {
Objects.requireNonNull(request, "request");
Objects.requireNonNull(requestOptions, "requestOptions");

com.azure.core.http.HttpRequest azureRequest = buildAzureRequest(request);
com.azure.core.http.HttpResponse azureResponse = this.azureHttpClient.sendSync(azureRequest, Context.NONE);
Comment thread
jpalvarezl marked this conversation as resolved.
Outdated
return new AzureHttpResponseAdapter(azureResponse);
}

@Override
public CompletableFuture<HttpResponse> executeAsync(HttpRequest request) {
return executeAsync(request, RequestOptions.none());
}

@Override
public CompletableFuture<HttpResponse> executeAsync(HttpRequest request, RequestOptions requestOptions) {
Objects.requireNonNull(request, "request");
Objects.requireNonNull(requestOptions, "requestOptions");

final com.azure.core.http.HttpRequest azureRequest;
try {
azureRequest = buildAzureRequest(request);
} catch (RuntimeException runtimeException) {
return failedFuture(runtimeException);
}

return this.azureHttpClient.send(azureRequest)
Comment thread
jpalvarezl marked this conversation as resolved.
Outdated
.map(AzureHttpResponseAdapter::new)
.map(response -> (HttpResponse) response)
Comment thread
jpalvarezl marked this conversation as resolved.
Outdated
.toFuture();
}

/**
* Converts the OpenAI request metadata and body into an Azure {@link com.azure.core.http.HttpRequest}.
*/
private static com.azure.core.http.HttpRequest buildAzureRequest(HttpRequest request) {
HttpRequestBody requestBody = request.body();
String contentType = requestBody != null ? requestBody.contentType() : null;
BinaryData bodyData = null;

if (requestBody != null) {
try {
bodyData = toBinaryData(requestBody);
Comment thread
jpalvarezl marked this conversation as resolved.
Outdated
} finally {
closeQuietly(requestBody);
Comment thread
jpalvarezl marked this conversation as resolved.
Outdated
}
}

HttpHeaders headers = toAzureHeaders(request.headers());
if (!CoreUtils.isNullOrEmpty(contentType) && headers.getValue(CONTENT_TYPE) == null) {
headers.set(CONTENT_TYPE, contentType);
}

com.azure.core.http.HttpRequest azureRequest
= new com.azure.core.http.HttpRequest(com.azure.core.http.HttpMethod.valueOf(request.method().name()),
OpenAiRequestUrlBuilder.buildUrl(request), headers);

if (bodyData != null) {
azureRequest.setBody(bodyData);
}

return azureRequest;
}

/**
* Copies OpenAI headers into an {@link HttpHeaders} instance so the Azure pipeline can process them.
*/
private static HttpHeaders toAzureHeaders(Headers sourceHeaders) {
HttpHeaders target = new HttpHeaders();
sourceHeaders.names().forEach(name -> {
List<String> values = sourceHeaders.values(name);
HttpHeaderName headerName = HttpHeaderName.fromString(name);
if (values.isEmpty()) {
target.set(headerName, "");
} else {
target.set(headerName, values);
}
});
return target;
}
Comment thread
jpalvarezl marked this conversation as resolved.

/**
* Buffers the OpenAI {@link HttpRequestBody} into {@link BinaryData} so it can be attached to the Azure
* request. The body is consumed exactly once and closed afterwards.
*/
private static BinaryData toBinaryData(HttpRequestBody requestBody) {
if (requestBody == null) {
return null;
}

try (ByteArrayOutputStream outputStream = new ByteArrayOutputStream()) {
requestBody.writeTo(outputStream);
return BinaryData.fromBytes(outputStream.toByteArray());
} catch (IOException e) {
throw LOGGER.logExceptionAsError(new UncheckedIOException("Failed to buffer request body", e));
}
}

/**
* Closes the OpenAI request body while suppressing any exceptions (to avoid masking the root cause).
*/
private static void closeQuietly(HttpRequestBody body) {
if (body == null) {
return;
}
try {
body.close();
} catch (Exception ignored) {
// no-op
}
}

/**
* Creates a failed {@link CompletableFuture} for callers that require a future even when conversion fails.
*/
private static <T> CompletableFuture<T> failedFuture(Throwable throwable) {
CompletableFuture<T> future = new CompletableFuture<>();
future.completeExceptionally(throwable);
return future;
}
}
}
Loading
Loading