-
Notifications
You must be signed in to change notification settings - Fork 2.2k
OpenAI.HttpClient to Azure.HttpClient mapper for test instrumentation #47416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jpalvarezl
merged 38 commits into
main
from
feature/stainless_httpclient_instrumentation
Dec 13, 2025
Merged
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
89496d3
Porting over changes from private repo
jpalvarezl eca457f
formatting
jpalvarezl 954ba7d
Update sdk/ai/azure-ai-agents/src/main/java/com/azure/ai/agents/imple…
jpalvarezl 4df3dba
Update sdk/ai/azure-ai-agents/src/main/java/com/azure/ai/agents/imple…
jpalvarezl 385e9b5
Formatting mismatch
jpalvarezl 0957fd2
Add async and error propagation test coverage for PolicyDecoratingHtt…
Copilot d113cc2
Add error handling tests for HttpClientHelper (#47428)
Copilot 224e3fb
Merged and improved assertions
jpalvarezl 672a6df
More PR feedback
jpalvarezl d4505e6
More PR feedback
jpalvarezl bf085da
More PR feedback
jpalvarezl 226c2c0
lazy mapping of types for the AzureHttpResponseAdapter
jpalvarezl 7c95643
Simplified mapping
jpalvarezl 867d0d6
Always using default httpPipeline
jpalvarezl 6bf38b7
Using bare minimum code
jpalvarezl 7c1b414
WIP: removing redundant code. Using default httpPipeline
jpalvarezl 96153b7
fix async tests
srnagar a4e5c29
Code style checks
jpalvarezl 8e760a9
Added recording for async test
jpalvarezl 94b0797
Merge branch 'main' into feature/stainless_httpclient_instrumentation
jpalvarezl b4bbdd3
Enabled sync tests and update assets
jpalvarezl b9a37e8
Updated test suite and restored value for context config
jpalvarezl ce40dab
Using latest version of azure-core-test
jpalvarezl a53bbd1
Forwarding request timeout and adding more custom machters for tests
jpalvarezl d9293fa
reassign addData result
jpalvarezl 27aa57f
WIP: timeout tests
jpalvarezl edcf29d
Timeout tests are run only in Live test mode
jpalvarezl 28d3d6e
Test asset update
jpalvarezl 275e2e9
Exceptions are allowed to propagate upwards
jpalvarezl 8c77862
Error mapping in place
jpalvarezl 2fcfb4d
reformat
jpalvarezl f4206bb
Format
jpalvarezl 67c9970
Fixed timeout tests
jpalvarezl 38694bb
PR feedback 1st round
jpalvarezl 6967620
PR feedback round 2: pom updates
jpalvarezl 41ca65d
dependency tag fixed and disabled test
jpalvarezl f0fc0ed
Disabled flacky timeout tests
jpalvarezl ad2d539
Disabled one more test
jpalvarezl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63 changes: 63 additions & 0 deletions
63
...gents/src/main/java/com/azure/ai/agents/implementation/http/AzureHttpResponseAdapter.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
|
|
||
| package com.azure.ai.agents.implementation.http; | ||
|
|
||
| import com.azure.core.http.HttpHeader; | ||
| import com.azure.core.http.HttpHeaders; | ||
| import com.azure.core.util.logging.ClientLogger; | ||
| import com.openai.core.http.Headers; | ||
| import com.openai.core.http.HttpResponse; | ||
|
|
||
| import java.io.InputStream; | ||
|
|
||
| /** | ||
| * Adapter that exposes an Azure {@link com.azure.core.http.HttpResponse} as an OpenAI {@link HttpResponse}. This keeps | ||
| * the translation logic encapsulated so response handling elsewhere can remain framework agnostic. | ||
| */ | ||
| final class AzureHttpResponseAdapter implements HttpResponse { | ||
|
|
||
| private static final ClientLogger LOGGER = new ClientLogger(AzureHttpResponseAdapter.class); | ||
|
|
||
| private final com.azure.core.http.HttpResponse azureResponse; | ||
|
|
||
| /** | ||
| * Creates a new adapter instance for the provided Azure response. | ||
| * | ||
| * @param azureResponse Response returned by the Azure pipeline. | ||
| */ | ||
| AzureHttpResponseAdapter(com.azure.core.http.HttpResponse azureResponse) { | ||
| this.azureResponse = azureResponse; | ||
| } | ||
|
|
||
| @Override | ||
| public int statusCode() { | ||
| return azureResponse.getStatusCode(); | ||
| } | ||
|
|
||
| @Override | ||
| public Headers headers() { | ||
| return toOpenAiHeaders(azureResponse.getHeaders()); | ||
| } | ||
|
|
||
| @Override | ||
| public InputStream body() { | ||
| return azureResponse.getBodyAsBinaryData().toStream(); | ||
| } | ||
|
|
||
| @Override | ||
| public void close() { | ||
| azureResponse.close(); | ||
| } | ||
|
|
||
| /** | ||
| * Copies headers from the Azure response into the immutable OpenAI {@link Headers} collection. | ||
| */ | ||
| private static Headers toOpenAiHeaders(HttpHeaders httpHeaders) { | ||
| Headers.Builder builder = Headers.builder(); | ||
| for (HttpHeader header : httpHeaders) { | ||
| builder.put(header.getName(), header.getValuesList()); | ||
| } | ||
| return builder.build(); | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.