Skip to content

Sync eng/common directory with azure-sdk-tools for PR 12734 #47136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Sync eng/common directory with azure-sdk-tools for PR 12734 #47136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dfd38a0
Use @azure-tools/cspell for spelling pin package name
danieljurek Oct 31, 2025
3b17128
add trailing newline
mikeharder Oct 31, 2025
d93dbcc
npm i
danieljurek Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions eng/common/spelling/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions eng/common/spelling/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "cspell-version-pin",
"version": "1.0.0",
"name": "@azure-tools/cspell",
Copy link

Copilot AI Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package.json should include a version field. Since this is a private package and not intended for publishing, it's best practice to include \"version\": \"1.0.0\" (or another appropriate version) for consistency with the lock file and standard npm package structure.

Suggested change
"name": "@azure-tools/cspell",
"name": "@azure-tools/cspell",
"version": "1.0.0",

Copilot uses AI. Check for mistakes.
"private": true,
"dependencies": {
"cspell": "^9.2.1"
"cspell": "9.2.1"
}
}