Sync eng/common directory with azure-sdk-tools for PR 12734 #47136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azure-sdk
added
EngSys
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the cspell configuration to use a scoped package name, marks it as private, and pins the cspell dependency to an exact version.
- Package name changed from
cspell-version-pinto@azure-tools/cspell - Added
"private": trueto prevent accidental publishing - Changed cspell dependency from flexible version
^9.2.1to exact version9.2.1
Reviewed Changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| eng/common/spelling/package.json | Updated package name to scoped format, added private flag, and pinned cspell to exact version |
| eng/common/spelling/package-lock.json | Updated lockfile to reflect new package name and exact version dependency |
Files not reviewed (1)
- eng/common/spelling/package-lock.json: Language not supported
| { | ||
| "name": "cspell-version-pin", | ||
| "version": "1.0.0", | ||
| "name": "@azure-tools/cspell", |
There was a problem hiding this comment.
The package.json should include a version field. Since this is a private package and not intended for publishing, it's best practice to include \"version\": \"1.0.0\" (or another appropriate version) for consistency with the lock file and standard npm package structure.
Suggested change
| "name": "@azure-tools/cspell", | |
| "name": "@azure-tools/cspell", | |
| "version": "1.0.0", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#12734 See eng/common workflow