[AutoPR azure-resourcemanager-dnsresolver]-generated-from-SDK Generation - Java-5425115#46924
Conversation
….Network/DnsResolver/tspconfig.yaml', API Version: 2025-10-01-preview, SDK Release Type: beta, and CommitSHA: '3ec630fc62ebc03e9adf238cb2fb0b538d93ead4' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5425115 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Azure DNS Resolver SDK for Java from API version 2025-05-01 to 2025-10-01-preview. The changes are generated by the TypeSpec Code Generator (replacing AutoRest) and include new functionality for managed domain lists in DNS security rules.
Key changes:
- Migration from AutoRest to TypeSpec code generation
- Addition of
managedDomainListsproperty to DNS security rules - Renaming of delete methods to
deleteByResourceGroupfor consistency with SDK patterns - Updates to JavaDoc descriptions and internal implementation details
Reviewed Changes
Copilot reviewed 115 out of 297 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| DnsSecurityRule.java | Added managedDomainLists property and updated builder pattern stages |
| DnsSecurityRulePatch.java | Added getter/setter methods for managedDomainLists property |
| DnsSecurityRuleImpl.java | Implemented managedDomainLists support in the implementation class |
| DnsResolvers.java, DnsResolverPolicies.java, etc. | Added deleteByResourceGroup methods and reordered method declarations |
| Multiple ListResult classes | Moved to implementation.models package and changed from @fluent to @immutable |
| DnsResolverManagementClientImpl.java | Updated API version from 2025-05-01 to 2025-10-01-preview |
| Comment header updates across ~40 files | Changed code generator attribution from AutoRest to TypeSpec |
Comments suppressed due to low confidence (6)
sdk/dnsresolver/azure-resourcemanager-dnsresolver/src/main/java/com/azure/resourcemanager/dnsresolver/models/DnsSecurityRule.java:1
- The JavaDoc for the
etagproperty contains malformed text with an extra quotation mark at the end and appears to be a direct copy of HTTP specification text. The description should be simplified and properly formatted for JavaDoc. Consider:Gets the etag property: ETag of the DNS security rule. Entity tags are used for comparing two or more entities from the same requested resource.
// Copyright (c) Microsoft Corporation. All rights reserved.
sdk/dnsresolver/azure-resourcemanager-dnsresolver/src/main/java/com/azure/resourcemanager/dnsresolver/models/DnsResolverPolicy.java:1
- The JavaDoc for the
etagproperty contains malformed text with an extra quotation mark at the end and appears to be a direct copy of HTTP specification text. The description should be simplified and properly formatted for JavaDoc. Consider:Gets the etag property: ETag of the DNS resolver policy. Entity tags are used for comparing two or more entities from the same requested resource.
// Copyright (c) Microsoft Corporation. All rights reserved.
sdk/dnsresolver/azure-resourcemanager-dnsresolver/src/main/java/com/azure/resourcemanager/dnsresolver/models/DnsResolverPolicyVirtualNetworkLink.java:1
- The JavaDoc for the
etagproperty contains malformed text with an extra quotation mark at the end and appears to be a direct copy of HTTP specification text. The description should be simplified and properly formatted for JavaDoc. Consider:Gets the etag property: ETag of the DNS resolver policy virtual network link. Entity tags are used for comparing two or more entities from the same requested resource.
// Copyright (c) Microsoft Corporation. All rights reserved.
sdk/dnsresolver/azure-resourcemanager-dnsresolver/src/main/java/com/azure/resourcemanager/dnsresolver/models/DnsResolverDomainList.java:1
- The JavaDoc for the
etagproperty contains malformed text with an extra quotation mark at the end and appears to be a direct copy of HTTP specification text. The description should be simplified and properly formatted for JavaDoc. Consider:Gets the etag property: ETag of the DNS resolver domain list. Entity tags are used for comparing two or more entities from the same requested resource.
// Copyright (c) Microsoft Corporation. All rights reserved.
sdk/dnsresolver/azure-resourcemanager-dnsresolver/src/main/java/com/azure/resourcemanager/dnsresolver/models/DnsResolver.java:1
- The JavaDoc for the
etagproperty contains malformed text with an extra quotation mark at the end and appears to be a direct copy of HTTP specification text. The description should be simplified and properly formatted for JavaDoc. Consider:Gets the etag property: ETag of the DNS resolver. Entity tags are used for comparing two or more entities from the same requested resource.
// Copyright (c) Microsoft Corporation. All rights reserved.
sdk/dnsresolver/azure-resourcemanager-dnsresolver/src/main/java/com/azure/resourcemanager/dnsresolver/models/DnsForwardingRuleset.java:1
- The JavaDoc for the
etagproperty contains malformed text with an extra quotation mark at the end and appears to be a direct copy of HTTP specification text. The description should be simplified and properly formatted for JavaDoc. Consider:Gets the etag property: ETag of the DNS forwarding ruleset. Entity tags are used for comparing two or more entities from the same requested resource.
// Copyright (c) Microsoft Corporation. All rights reserved.
Configurations: 'specification/dnsresolver/resource-manager/Microsoft.Network/DnsResolver/tspconfig.yaml', API Version: 2025-10-01-preview, SDK Release Type: beta, and CommitSHA: '3ec630fc62ebc03e9adf238cb2fb0b538d93ead4' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5425115 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=61053214-6a8e-f011-b4cc-0022480bb79b Submitted by: jamesvoong@microsoft.com
Release Plan Details
Spec pull request: Add 2025-10-01-preview changes to dns resolver azure-rest-api-specs#37724
Spec API version: 2025-10-01-preview