Skip to content

Comments

Add 2025-10-01-preview changes to dns resolver#37724

Merged
jamesvoongms merged 6 commits intoAzure:mainfrom
jamesvoongms:release-dns-resolver-2025-10-01-preview
Oct 7, 2025
Merged

Add 2025-10-01-preview changes to dns resolver#37724
jamesvoongms merged 6 commits intoAzure:mainfrom
jamesvoongms:release-dns-resolver-2025-10-01-preview

Conversation

@jamesvoongms
Copy link
Member

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
  • A release plan has been created. If not, please create one as it will help guide you through the REST API and SDK creation process.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.
  • For guidance on SDK breaking change review, refer to https://aka.ms/ci-fix.

@github-actions
Copy link

github-actions bot commented Sep 24, 2025

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Comment generated by summarize-checks workflow run.

@github-actions github-actions bot added ARMReview new-api-version resource-manager TypeSpec Authored with TypeSpec WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 24, 2025
@github-actions
Copy link

github-actions bot commented Sep 24, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
TypeSpec Microsoft.Network
Go sdk/resourcemanager/dnsresolver/armdnsresolver
JavaScript @azure/arm-dnsresolver
Java com.azure.resourcemanager:azure-resourcemanager-dnsresolver

@github-actions github-actions bot added ARMAutoSignedOff ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required NotReadyForARMReview and removed ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 24, 2025
@jamesvoongms
Copy link
Member Author

Hi team, please see the private repo review approved by my team here: https://github.com/Azure/azure-rest-api-specs-pr/pull/24470.

Could someone provide guidance on how i should approach the breaking change? We are making a property from required to optional which is flagging breaking change.

@github-actions github-actions bot removed the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Sep 24, 2025
@mikekistler mikekistler added the BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. label Sep 27, 2025
@github-actions github-actions bot added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed NotReadyForARMReview ARMAutoSignedOff labels Sep 27, 2025
@ravimeda
Copy link
Member

ravimeda commented Oct 2, 2025

      "202": {

202 for PUT is not recommended. #Resolved


Refers to: specification/dnsresolver/resource-manager/Microsoft.Network/DnsResolver/preview/2025-10-01-preview/openapi.json:430 in abba0c9. [](commit_id = abba0c9, deletion_comment = False)

@ravimeda
Copy link
Member

ravimeda commented Oct 2, 2025

        "$ref": "../../../../../../common-types/resource-management/v5/types.json#/parameters/ApiVersionParameter"

Use v6. #Resolved


Refers to: specification/dnsresolver/resource-manager/Microsoft.Network/DnsResolver/preview/2025-10-01-preview/openapi.json:83 in abba0c9. [](commit_id = abba0c9, deletion_comment = False)

Copy link
Member

@ravimeda ravimeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@ravimeda ravimeda added ARMChangesRequested and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 2, 2025
@github-actions github-actions bot added ARMAutoSignedOff ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested labels Oct 2, 2025
@jamesvoongms
Copy link
Member Author

jamesvoongms commented Oct 2, 2025

@ravimeda , the 202 return pattern is for our old set of resources that we have not yet moved to the 201 pattern. However our new resources are now using the 201 pattern (that are being changed here in this changeset) #Resolved

@jamesvoongms
Copy link
Member Author

jamesvoongms commented Oct 2, 2025

@ravimeda I have changed the new version 2025-10-01-preview to now use v6 as requested #Resolved

@jamesvoongms jamesvoongms requested a review from ravimeda October 2, 2025 21:50
@ravimeda
Copy link
Member

ravimeda commented Oct 6, 2025

Keep the 202 for existing resources. Only for the new RTs avoid 202 for PUT.


In reply to: 3363070712

@ravimeda
Copy link
Member

ravimeda commented Oct 6, 2025

      "202": {

To clarify, this applies to only new resource types (and not new versions of existing resource types).


In reply to: 3362884285


Refers to: specification/dnsresolver/resource-manager/Microsoft.Network/DnsResolver/preview/2025-10-01-preview/openapi.json:430 in abba0c9. [](commit_id = abba0c9, deletion_comment = False)

Copy link
Member

@ravimeda ravimeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jamesvoongms jamesvoongms added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Oct 7, 2025
@jamesvoongms jamesvoongms merged commit f3b08b0 into Azure:main Oct 7, 2025
37 of 41 checks passed
pmoana-ms pushed a commit that referenced this pull request Oct 23, 2025
* Add 2025-10-01-preview changes to dns resolver

* Upgrade to v6 for common types

* Add emitter output dir for c#

* Fix Namespace of c# output

* Add emitter output dir for python and ts
qiaozha pushed a commit to Azure/azure-sdk-for-js that referenced this pull request Nov 14, 2025
…25113 (#36130)

Configurations:
'specification/dnsresolver/resource-manager/Microsoft.Network/DnsResolver/tspconfig.yaml',
API Version: 2025-10-01-preview, SDK Release Type: beta, and CommitSHA:
'3ec630fc62ebc03e9adf238cb2fb0b538d93ead4' in SpecRepo:
'https://github.com/Azure/azure-rest-api-specs' Pipeline run:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5425113
Refer to
https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites
to prepare for SDK release. **Release plan link:**
[https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=61053214-6a8e-f011-b4cc-0022480bb79b](https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=61053214-6a8e-f011-b4cc-0022480bb79b)
**Submitted by**: jamesvoong@microsoft.com
## Release Plan Details
- Release Plan:
https://aka.ms/sdk-release-planner?release-plan-id=61053214-6a8e-f011-b4cc-0022480bb79b
Spec pull request:
Azure/azure-rest-api-specs#37724
Spec API version: 2025-10-01-preview

---------

Co-authored-by: kazrael2119 <98569699+kazrael2119@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMAutoSignedOff ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required new-api-version PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager TypeSpec Authored with TypeSpec

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants