Skip to content

Make changes to the changelog #4342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sima-zhu merged 6 commits into from
Jul 24, 2019
Merged

Make changes to the changelog #4342

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5529a59
Addressed feedback
sima-zhu Jul 9, 2019
4cda809
Addressed comments for changelog
sima-zhu Jul 10, 2019
de1f957
Addressed comments.
sima-zhu Jul 15, 2019
15875a1
Addressed the comments.
sima-zhu Jul 23, 2019
3a2d2d8
Minor changes
sima-zhu Jul 23, 2019
eea1bf3
Correct typo of blobClient
sima-zhu Jul 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions storage/client/blob/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ https://aka.ms/azure-sdk-preview1-java.

**Breaking changes: New API design**
- Operations are now scoped to a particular client:
- `StorageClient`: This client handles account-level operations. This includes managing service properties and listing the containers within an account.
- `ContainerClient`: The client handles operations for a particular container. This includes creating or deleting that container, as well as listing the blobs within that container and managing properties and metadata.
- `BlobClient`: The client handles operations for a particular blob. This includes creating or deleting that blob, as well as upload and download data and managing properties.
This BlobClient handles all blob types (block, page and append). Where operations can behave differently according to type (i.e. `upload`) the default behaviour will be block blobs unless otherwise specified.
- `StorageClient`: The StorageURL renamed to StorageClient. This client handles account-level operations. This includes managing service properties and listing the containers within an account.
Comment thread
alzimmermsft marked this conversation as resolved.
Outdated
- `ContainerClient`: The ContainerURL renamed to ContainerClient. The client handles operations for a particular container. This includes creating or deleting that container, as well as listing the blobs within that container.
- `BlobClient`: The BlobURL renamed to BlobClient. The client handles operations for a particular blob. This includes upload and download data.

@jaschrep-msft jaschrep-msft Jul 9, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except we can't upload data with this client. I would have the last sentence be This includes downloading data and working with blob properties.

@jaschrep-msft jaschrep-msft Jul 9, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also change a particular blob to an individual blob. I read "particular blob" and I think you're talking about the difference between block/page/append blobs, even more confusing when we talk about those on the very next line.

handles operations -> handles most operations, excluding upload,

@sima-zhu sima-zhu Jul 10, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

There are subclients (BlockBlobClient, PageBlobClient, AppendBlobClient) available through all blob types (block, page and append), where operations can behave differently according to type (i.e. `upload`).

@jaschrep-msft jaschrep-msft Jul 9, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

available through all blob types (block, page, and append), -> available for their respective blob types on the service

Also, it feels weird to say operations behave differently. They are either there or they are not. The only functionality that would behave differently with the same terminology would be blob input/output streams and uploadfromfile, but those aren't on the base class, so there's no method who's functionality is really changing.

@sima-zhu sima-zhu Jul 10, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your comments. I will address these.


These clients can be accessed by navigating down the client hierarchy, or instantiated directly using builder to the resource (account, container or blob).
- New module level operations for simple upload and download using a block or page blob client.
Expand Down