Conversation
storage/client/blob/CHANGELOG.md
Outdated
| This BlobClient handles all blob types (block, page and append). Where operations can behave differently according to type (i.e. `upload`) the default behaviour will be block blobs unless otherwise specified. | ||
| - `StorageClient`: The StorageURL renamed to StorageClient. This client handles account-level operations. This includes managing service properties and listing the containers within an account. | ||
| - `ContainerClient`: The ContainerURL renamed to ContainerClient. The client handles operations for a particular container. This includes creating or deleting that container, as well as listing the blobs within that container. | ||
| - `BlobClient`: The BlobURL renamed to BlobClient. The client handles operations for a particular blob. This includes upload and download data. |
There was a problem hiding this comment.
Except we can't upload data with this client. I would have the last sentence be This includes downloading data and working with blob properties.
There was a problem hiding this comment.
I'd also change a particular blob to an individual blob. I read "particular blob" and I think you're talking about the difference between block/page/append blobs, even more confusing when we talk about those on the very next line.
handles operations -> handles most operations, excluding upload,
storage/client/blob/CHANGELOG.md
Outdated
| - `StorageClient`: The StorageURL renamed to StorageClient. This client handles account-level operations. This includes managing service properties and listing the containers within an account. | ||
| - `ContainerClient`: The ContainerURL renamed to ContainerClient. The client handles operations for a particular container. This includes creating or deleting that container, as well as listing the blobs within that container. | ||
| - `BlobClient`: The BlobURL renamed to BlobClient. The client handles operations for a particular blob. This includes upload and download data. | ||
| There are subclients (BlockBlobClient, PageBlobClient, AppendBlobClient) available through all blob types (block, page and append), where operations can behave differently according to type (i.e. `upload`). |
There was a problem hiding this comment.
available through all blob types (block, page, and append), -> available for their respective blob types on the service
Also, it feels weird to say operations behave differently. They are either there or they are not. The only functionality that would behave differently with the same terminology would be blob input/output streams and uploadfromfile, but those aren't on the base class, so there's no method who's functionality is really changing.
There was a problem hiding this comment.
Thanks for your comments. I will address these.
storage/client/blob/CHANGELOG.md
Outdated
| This BlobClient handles all blob types (block, page and append). Where operations can behave differently according to type (i.e. `upload`) the default behaviour will be block blobs unless otherwise specified. | ||
| - `StorageClient`: StorageURL's functionality was migrated to StorageClient. This client handles account-level operations. This includes managing service properties and listing the containers within an account. | ||
| - `ContainerClient`: ContainerURL's functionality was migrated to ContainerClient. The client handles operations for a particular container. This includes creating or deleting that container, as well as listing the blobs within that container. | ||
| - `BlobClient`: StorageURL's functionality was migrated to StorageClient. The client handles most operations, excluding upload, for an individual blob, including downloading data and working with blob properties. |
There was a problem hiding this comment.
Shouldn't it be "BlobURL's functionality was migrated to BlobClient?
Can you also mention that TransferManager downloads were moved to BlobClient and TransferManager uploads were moved to BlockBlobClient?
There was a problem hiding this comment.
Addressed the comments.
There was a problem hiding this comment.
Line 12 should say BlobClient not StorageClient.
alzimmermsft
left a comment
alzimmermsft
left a comment
There was a problem hiding this comment.
LGTM, just replace the StorageClient name where BlobClient was expected.
|
The PR corrects some basic thing for changelog. |
4 participants
No description provided.