Fix AccessTokenUtil does not url encode its parameters #40697
Merged
+13
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rujche
commented
Jun 19, 2024
| .append(RESOURCE_FRAGMENT).append(resource); | ||
| .append(CLIENT_ID_FRAGMENT).append(URLEncoder.encode(clientId, StandardCharsets.UTF_8)) | ||
| .append(CLIENT_SECRET_FRAGMENT).append(URLEncoder.encode(clientSecret, StandardCharsets.UTF_8)) | ||
| .append(RESOURCE_FRAGMENT).append(URLEncoder.encode(resource, StandardCharsets.UTF_8)); |
Member
Author
There was a problem hiding this comment.
FYI:
- According to the ms doc, every parameters should url encoded, not encode one specific parameter nor the whole requestBody.
- According to the ms doc, the parameter should be
scope, notresource. I don't know why it useresourcehere. Anyway, I just keep the original behavior.
Collaborator
|
API change check API changes are not detected in this pull request. |
Member
Author
|
Hi, @saragluna , please help to review this PR. |
Member
Author
@saragluna |
Member
Author
|
/azp run java - keyvault - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run java - keyvault - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Netyyyy
pushed a commit
to Netyyyy/azure-sdk-for-java
that referenced
this pull request
Jul 11, 2024
* Fix bug: clientSecret not url encoded. (cherry picked from commit eb0d42f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #40616
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines